Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace swap slider with swap button #12030

Merged
merged 6 commits into from
Oct 28, 2024
Merged

refactor: replace swap slider with swap button #12030

merged 6 commits into from
Oct 28, 2024

Conversation

bfullam
Copy link
Contributor

@bfullam bfullam commented Oct 25, 2024 •
edited
Loading

Description

Feedback was received suggesting that the "swipe to swap" UI was often navigating back instead of executing the swap. This PR replaces the swipe with a button to address this issue and simplify the interaction.

Related issues

Fixes:

Manual testing steps

  1. Go to the swap page
  2. Get quotes
  3. See swap button

Screenshots/Recordings

Before

Screenshot 2024-10-25 at 17 22 47

After

Screenshot 2024-10-25 at 17 24 04

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bfullam bfullam requested review from a team as code owners October 25, 2024 15:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bfullam
Copy link
Contributor Author

bfullam commented Oct 25, 2024

I have read the CLA Document and I hereby sign the CLA

@bfullam bfullam added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 14dfa03
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2eae2fdb-6d4f-4aa0-935e-8f5ce310d7bb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@bfullam bfullam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dd4be43
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/03661f39-66f1-401f-986a-c324bb5ae32f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bfullam bfullam added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7143ffd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/12987195-c949-4ff7-84b4-69d5695368d7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bfullam bfullam enabled auto-merge October 28, 2024 17:07
davibroc
davibroc approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@davibroc davibroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it and it works

@davibroc davibroc added the QA Passed A successful QA run through has been done label Oct 28, 2024
sethkfman
sethkfman approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only reviewed locales changes

@bfullam bfullam added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit a2de45b Oct 28, 2024
46 checks passed
@bfullam bfullam deleted the MMS-1591-restyle-swap-button branch October 28, 2024 19:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethkfman sethkfman sethkfman approved these changes

@jclancy93 jclancy93 jclancy93 approved these changes

@davibroc davibroc davibroc approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-swaps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bfullam @davibroc @jclancy93 @sethkfman @metamaskbot