-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add max tooltip for staking with gas fee consideration #12025
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
14b2fc1
to
bb52808
Compare
bb52808
to
14b3fb9
Compare
a737356
to
fd5aee6
Compare
Bitrise✅✅✅ Commit hash: 0bbf6d4 Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12025 +/- ##
==========================================
+ Coverage 55.35% 55.53% +0.18%
==========================================
Files 1767 1776 +9
Lines 39841 40058 +217
Branches 4965 4987 +22
==========================================
+ Hits 22052 22248 +196
- Misses 16274 16285 +11
- Partials 1515 1525 +10 ☔ View full report in Codecov by Sentry. |
0bbf6d4
to
e702374
Compare
Bitrise✅✅✅ Commit hash: 134e0e2 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor comment but otherwise LGTM! Awesome work 🚀
Bitrise✅✅✅ Commit hash: 1ce4838 Note
|
Quality Gate passedIssues Measures |
app/components/UI/Stake/components/StakingBalance/StakingBanners/ClaimBanner/ClaimBanner.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR renders the max input modal component when the user clicks on the max button on the stake input screen. This is also responsible for subtracting the gas fees from the available balance before letting the user continue to the deposit flow.
This PR also makes some minor changes and refactors as described below:
Related issues
Fixes: STAKE-847
Manual testing steps
Screenshots/Recordings
New : Max Input Modal
Max_Input_Modal.mp4
Navbar alignment Fix
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist