Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 #12024

Merged
merged 2 commits into from
Oct 29, 2024
Merged

chore: eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 #12024

merged 2 commits into from
Oct 29, 2024
+18 −26

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 25, 2024 •
edited
Loading

Description

Replace deprecated eth-json-rpc-filters with @metamask/eth-json-rpc-filters.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat changed the title deps: eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 chore eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 Oct 25, 2024
@legobeat legobeat added dependencies Pull requests that update a dependency file Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 25, 2024
@legobeat legobeat changed the title chore eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 chore: eth-json-rpc-filters@^6.0.1 -> @metamask/eth-json-rpc-filters@^8.0.0 Oct 25, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Oct 25, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-json-rpc-filters@8.0.0 None 0 24.4 kB lgbot

🚮 Removed packages: npm/eth-json-rpc-filters@6.0.1, npm/eth-query@2.1.2

View full report↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8c971a8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7e31c470-67c0-47c1-9103-0412b7e29c3a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat marked this pull request as ready for review October 25, 2024 03:09
@legobeat legobeat requested review from a team as code owners October 25, 2024 03:10
@legobeat legobeat mentioned this pull request Oct 25, 2024
Draft
12 tasks
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-8 branch from 8c971a8 to 70e9402 Compare October 25, 2024 22:11
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 70e9402
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e2b06257-099f-40c3-93c2-afc1bf356465

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

This was referenced Oct 28, 2024
Merged
Closed
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-8 branch from 70e9402 to 887febd Compare October 28, 2024 10:39
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 887febd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/061a0004-85bb-42f8-8eb4-86a45cbbe13c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat mentioned this pull request Oct 28, 2024
Merged
7 tasks
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-8 branch from 887febd to 1a73659 Compare October 28, 2024 21:01
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-8 branch 2 times, most recently from 5de4d65 to 91fbb80 Compare October 29, 2024 04:04
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 91fbb80
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e5e52ad1-9c78-4766-922e-acc2d8e353b0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat enabled auto-merge October 29, 2024 07:04
@legobeat legobeat force-pushed the deps-eth-json-rpc-filters-8 branch from 91fbb80 to 965efb0 Compare October 29, 2024 09:49
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 965efb0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/10b24db6-ce19-4cfe-8bb1-befcdc58c901

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@legobeat legobeat added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit c773d7a Oct 29, 2024
43 checks passed
@legobeat legobeat deleted the deps-eth-json-rpc-filters-8 branch October 29, 2024 12:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@FrederikBolding FrederikBolding FrederikBolding approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-security team-wallet-framework
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legobeat @FrederikBolding @tommasini @metamaskbot