Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Move portfolio connect out of quarantine #12023

Merged
merged 2 commits into from
Oct 28, 2024
Merged

test: Move portfolio connect out of quarantine #12023

merged 2 commits into from
Oct 28, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Oct 24, 2024 •
edited
Loading

Description

The Purpose of this task is to readd the portfolio connect e2e to the regression tag.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko self-assigned this Oct 24, 2024
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 28, 2024
@cortisiko cortisiko marked this pull request as ready for review October 28, 2024 18:28
@cortisiko cortisiko requested a review from a team as a code owner October 28, 2024 18:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7532b0b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/441b01d5-b428-4a5f-b75a-fd7ea0645326

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

MarioAslau
MarioAslau approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f84e04
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e2e82c7a-313e-49c8-9d3c-57b38d1d2a58

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit f416328 Oct 28, 2024
43 checks passed
@cortisiko cortisiko deleted the detox/move-portfolio-connect-e2e-out-of-quarantine branch October 28, 2024 19:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees

@cortisiko cortisiko

Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cortisiko @MarioAslau @metamaskbot