-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: STAKE-802 integrate claim sdk method #12018
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: e662c66 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised some questions but otherwise LGTM!
Also, it may be tackled in a separate PR or same but I noticed that when you try to edit the gas fees on the confirmation modal it gives out an error.
I noticed this too. I haven't looked into it yet though. I wasn't sure if it was something that needed fixing on the confirmation side. |
Bitrise✅✅✅ Commit hash: eb5e7a1 Note
|
Quality Gate passedIssues Measures |
Description
This PR adds native mobile support for claiming pool staked ETH.
Related issues
Jira Ticket: [FE] [Unstake flow] Integrate unstake method from sdk (link)
Manual testing steps
prerequisite: if you don't have any Ethereum unstaked to claim, you'll need to unstake some ETH first.
export MM_POOLED_STAKING_UI_ENABLED=true
to.js.env
file.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist