Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STAKE-802 integrate claim sdk method #12018

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Oct 24, 2024

Description

This PR adds native mobile support for claiming pool staked ETH.

Related issues

Jira Ticket: [FE] [Unstake flow] Integrate unstake method from sdk (link)

Manual testing steps

prerequisite: if you don't have any Ethereum unstaked to claim, you'll need to unstake some ETH first.

  1. Add export MM_POOLED_STAKING_UI_ENABLED=true to .js.env file.
  2. Click on Ethereum from the asset list page
  3. Click on "Claim ETH" text button
  4. Click "Confirm" on the transaction-controller confirmation screen.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 added team-stake Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-identity labels Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e662c66
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d37e9eb-24c0-4d43-b8f4-d8c5c108a924

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Matt561 Matt561 marked this pull request as ready for review October 24, 2024 22:21
@Matt561 Matt561 requested a review from a team as a code owner October 24, 2024 22:21
@Matt561 Matt561 requested a review from amitabh94 October 24, 2024 22:21
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised some questions but otherwise LGTM!

Also, it may be tackled in a separate PR or same but I noticed that when you try to edit the gas fees on the confirmation modal it gives out an error.

@Matt561
Copy link
Contributor Author

Matt561 commented Oct 25, 2024

Raised some questions but otherwise LGTM!

Also, it may be tackled in a separate PR or same but I noticed that when you try to edit the gas fees on the confirmation modal it gives out an error.

I noticed this too. I haven't looked into it yet though. I wasn't sure if it was something that needed fixing on the confirmation side.

@Matt561 Matt561 requested a review from amitabh94 October 25, 2024 14:22
@Matt561 Matt561 requested a review from amitabh94 October 25, 2024 15:05
@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 25, 2024
Copy link
Contributor

github-actions bot commented Oct 25, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: eb5e7a1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5460dbe8-8865-41c2-8d13-71aa881f8ce8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@Matt561 Matt561 added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit ead35c4 Oct 25, 2024
43 checks passed
@Matt561 Matt561 deleted the feat/stake-802-integrate-claim-sdk-method branch October 25, 2024 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants