Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade assets-controllers v37 #11988

Merged
merged 22 commits into from
Oct 30, 2024
Merged

chore: upgrade assets-controllers v37 #11988

merged 22 commits into from
Oct 30, 2024
+310 −282

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Oct 23, 2024 •
edited
Loading

Description

Updates assets-controllers to v37

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Oct 23, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@37.0.0 None +3 2.13 MB metamaskbot
npm/@metamask/eth-json-rpc-middleware@11.0.2 network +5 1.61 MB metamaskbot
npm/@metamask/eth-json-rpc-provider@1.0.1 None 0 21.8 kB metamaskbot
npm/@metamask/preferences-controller@11.0.0 Transitive: network +2 694 kB metamaskbot
npm/multiformats@13.3.0 None 0 325 kB npm-service-account-multiformats

🚮 Removed packages: npm/@metamask/assets-controllers@36.0.0, npm/@metamask/preferences-controller@13.0.3

View full report↗︎

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bc7ce34
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cdf64c5e-8445-4a8b-bf70-3f44704840a7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3498b5f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d4833a2-6e45-4a55-ba7c-0545e99eb001

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 579f48a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dbcddc06-a4f5-4fb3-a861-ed849e2590e3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 29, 2024
@sahar-fehri sahar-fehri requested review from a team as code owners October 30, 2024 12:18
@sahar-fehri
Copy link
Contributor Author

@SocketSecurity ignore npm/@metamask/eth-json-rpc-provider@1.0.1
@SocketSecurity ignore npm/@metamask/eth-sig-util@6.0.2

@sahar-fehri
Copy link
Contributor Author

Ignoring the Risk because we trust new authors

@sahar-fehri sahar-fehri requested review from a team October 30, 2024 13:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 30, 2024
@sahar-fehri sahar-fehri removed this pull request from the merge queue due to a manual request Oct 30, 2024
@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 30, 2024
@sahar-fehri sahar-fehri removed this pull request from the merge queue due to a manual request Oct 30, 2024
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit dceb552 Oct 30, 2024
37 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/upgrade-assets-controllers-v37.0.0 branch October 30, 2024 22:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@tommasini tommasini tommasini approved these changes

@gambinish gambinish gambinish approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@amitabh94 amitabh94 amitabh94 approved these changes

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sahar-fehri @amitabh94 @Prithpal-Sooriya @gambinish @tommasini @cryptodev-2s @metamaskbot