test: Refactor SendLinkView.js & TokenOverview.js files to follow page object model

[SamuelSalas]

Description

We are aiming to refactor the page objects in the modal folder so that they strictly follow the page object model pattern. This would aide in providing more readable and help standardize the way we create our tests. Because of the amount of files remaining, this issue will focus on working on three files to refactor, as well as their respective testIDS.

Files inside the scope for this batch:

• SendLinkView.js
• TokenOverview.js

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Regression Test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/73c51633-f930-4f5f-874e-1d7338f508ee

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: e660c12
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ccd6c7fc-c6ab-49a8-bd12-e816440c8d93

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 3ea8c49
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d74aeb8e-0b29-4883-a8c0-98592cbef15c

Note

• This comment will auto-update when build completes
• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b2dee48
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5e805831-35ef-4dfd-a20f-9e2ba8a96d4b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[cortisiko]

small feedback

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f740978
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6ab6674e-c299-42e5-977f-110e6a7cbf99

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud