Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explicitely make platform team owners of metrics system #11981

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

NicolasMassart
Copy link
Contributor

Description

explicitely make platform team owners of metrics system

Related issues

Fixes risk of PRs changing the metrics system without platform team review

Manual testing steps

N/A

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NicolasMassart NicolasMassart requested a review from a team as a code owner October 23, 2024 14:49
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicolasMassart NicolasMassart added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 23, 2024
@NicolasMassart NicolasMassart self-assigned this Oct 23, 2024
Copy link

@NicolasMassart NicolasMassart added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 8b7f955 Oct 23, 2024
48 checks passed
@NicolasMassart NicolasMassart deleted the chore/add_code_owner_for_metrics branch October 23, 2024 15:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 23, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.35.0 Issue or pull request that will be included in release 7.35.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants