Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tags to custom spans #11977

Merged
merged 37 commits into from
Oct 23, 2024
Merged

chore: add tags to custom spans #11977

merged 37 commits into from
Oct 23, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Oct 23, 2024 •
edited
Loading

Description

Cherry-picked this PR

Android build: https://app.bitrise.io/build/3cf918b6-a0b8-4a46-a3e8-78ebd74b9006

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

MarioAslau and others added 30 commits October 2, 2024 19:02
@MarioAslau
feat: Add custom traces
3071e27
@MarioAslau
feat: add custom operation name
f2c4baf
@MarioAslau
feat: revert integrations hardcode
e13f650
@MarioAslau
Merge branch 'main' into feat/1940-add-custom-sentry-span
ece30ea
@MarioAslau
feat: updated Spans
7faddb9
@MarioAslau
feat: add op for Load Scripts trace
d204e06
@MarioAslau
Merge branch 'main' into feat/1940-add-custom-sentry-span
13f9704
@MarioAslau
feat: fix main merge
a405e11
@MarioAslau
feat: add custom span for biometrics
adc9bb9
@MarioAslau
feat: trace file lint
6ecba9e
@MarioAslau
Merge branch 'main' into feat/1940-add-custom-sentry-span
c13b801
@MarioAslau
feat: remove console.log
62dd6e7
@MarioAslau
Merge branch 'feat/1940-add-custom-sentry-span' of https://github.com…
b1f17cb 
…/MetaMask/metamask-mobile into feat/1940-add-custom-sentry-span
@MarioAslau
Merge branch 'main' into feat/1940-add-custom-sentry-span
92d0d16
@MarioAslau
feat: onboarding tweak
3dbdbdd
@MarioAslau
Merge branch 'feat/1940-add-custom-sentry-span' of https://github.com…
363c9d0 
…/MetaMask/metamask-mobile into feat/1940-add-custom-sentry-span
@MarioAslau
feat: engine tweak
7813162
@MarioAslau
Merge branch 'main' into feat/1940-add-custom-sentry-span
2e8439b
@MarioAslau
feat: triggerLogIn tweak
28bb5b9
@MarioAslau
Merge branch 'feat/1940-add-custom-sentry-span' of https://github.com…
13f7674 
…/MetaMask/metamask-mobile into feat/1940-add-custom-sentry-span
@MarioAslau
feat: fix Engine Init crash
143731f
@MarioAslau
Merge branch 'main' into feat/1940-add-custom-sentry-span
3e97438
@tommasini
remove load scripts and UI startup span
d10dddd
@tommasini
Merge branch 'main' into feat/1940-add-custom-sentry-span
7a36882
@tommasini
remove unused import
f6adb4c
@tommasini
re add trance UI Startup
b69ed01
@tommasini
add test coverage to trace calls
43a7597
@tommasini
Merge branch 'main' into feat/1940-add-custom-sentry-span
a7c2540
@tommasini
Merge branch 'main' into feat/1940-add-custom-sentry-span
5e744a0
@MarioAslau
Merge branch 'main' into feat/1940-add-custom-sentry-span
1a93300
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b9d09e2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58e70906-1cb5-47b8-890d-446c38b095c3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

MarioAslau
MarioAslau approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 26fa10b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a9b237ec-9171-402d-8172-3c5a132cb4e7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

MarioAslau
MarioAslau previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feat/1940-add-custom-sentry-span to main October 23, 2024 15:42
@tommasini tommasini dismissed MarioAslau’s stale review October 23, 2024 15:42

The base branch was changed.

@github-actions github-actions bot requested a review from a team as a code owner October 23, 2024 15:42
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7e2d6dd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/70080bbf-3421-431b-9ede-2344e417fb99

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: aa2f297
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/aa602d66-97c9-4d6e-a906-07a41e33ef39

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tommasini tommasini added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 475e9bf Oct 23, 2024
43 checks passed
@tommasini tommasini deleted the chore/add-tags-to-custom-spans branch October 23, 2024 21:51
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MarioAslau MarioAslau MarioAslau approved these changes

Assignees
No one assigned
Labels
area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tommasini @MarioAslau @metamaskbot