-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(3417): sensitive text component #11965
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 5e5b369 Note
|
app/component-library/components/Texts/SensitiveText/SensitiveText.types.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vinnyhoward! This is looking fantastic 💯 also great docs and tests. I left some comments but otherwise really nice work 👍
@Akatori-Design is this something we can add to the Figma library?
app/component-library/components/Texts/SensitiveText/SensitiveText.types.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Texts/SensitiveText/SensitiveText.types.ts
Outdated
Show resolved
Hide resolved
app/component-library/components/Texts/SensitiveText/SensitiveText.types.ts
Show resolved
Hide resolved
app/component-library/components/Texts/SensitiveText/SensitiveText.types.ts
Outdated
Show resolved
Hide resolved
Bitrise🔄🔄🔄 Commit hash: fdead54 Note
|
Bitrise🔄🔄🔄 Commit hash: dde7225 Note
|
Bitrise✅✅✅ Commit hash: ebd5bcd Note
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11965 +/- ##
==========================================
+ Coverage 54.65% 55.13% +0.47%
==========================================
Files 1744 1755 +11
Lines 39333 39588 +255
Branches 4878 4929 +51
==========================================
+ Hits 21497 21825 +328
+ Misses 16340 16259 -81
- Partials 1496 1504 +8 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: d462829 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
…s to dots based on design feedback
Bitrise❌❌❌ Commit hash: bc4de57 Note
Tip
|
Quality Gate passedIssues Measures |
Bitrise✅✅✅ Commit hash: 504de25 Note
|
Description
Overview
This PR introduces a new
SensitiveText
component to our component library. TheSensitiveText
component extends our existingText
component to handle sensitive information, providing the ability to hide or show text content as needed.Features
Text
component functionalityText
component (variants, colors, etc)Related issues
Feature: #3417
Manual testing steps
Screenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Pre-merge reviewer checklist