feat(2808): edit network permissions #11963

EtherWizard33 · 2024-10-22T22:02:55Z

Description

add and remove permissions to network

Related issues

Contributes to solve issue: https://github.com/MetaMask/MetaMask-planning/issues/2808

Manual testing steps

I have added screenshot below to see how it looks.

Set these following variables in js.env, otherwise none of these screens will show.
export MM_NETWORK_UI_REDESIGN_ENABLED="1"
export MM_MULTICHAIN_V1_ENABLED="1"
export MM_CHAIN_PERMISSIONS="1"

Go to the in-app brower on the mobile wallet, connect to a dapp like uniswap
Click on the icon on top right header, a bottom sheet opens, click on the manage permissions button
Edit permissions, and confirm, when going back to the screen, permissions should be kept.

Screenshots/Recordings

Before, user was prompted to give permission	After, user gave permission and is not prompted to give it

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…at can be selected

… in some case this modal is displayed when switching from the global selector

github-actions · 2024-10-22T22:03:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…ng more than needed and it made the snapshot fail, TY snapshots.

…ing the connected flow

github-actions · 2024-10-23T02:25:13Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9087c64
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e004f589-acd6-4ee7-a4c0-8cfd97482e63

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…avatar group

github-actions · 2024-10-23T03:21:59Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 850e31d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/16f1256b-1a03-4fb7-a021-721dfe8350c6

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-10-23T23:30:00Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8c6d4be
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/34239b62-c787-464b-8b68-225edf2a8bb2

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…est on new code

codecov-commenter · 2024-10-23T23:55:18Z

Codecov Report

Attention: Patch coverage is 24.77064% with 82 lines in your changes missing coverage. Please review.

Project coverage is 55.18%. Comparing base (5e5190f) to head (97d3f43).
Report is 32 commits behind head on main.

Files with missing lines	Patch %	Lines
...nnectMultiSelector/NetworkConnectMultiSelector.tsx	0.00%	43 Missing ⚠️
...components/Views/AccountConnect/AccountConnect.tsx	36.66%	15 Missing and 4 partials ⚠️
...ts/Views/AccountPermissions/AccountPermissions.tsx	50.00%	9 Missing and 3 partials ⚠️
...etworkVerificationInfo/NetworkVerificationInfo.tsx	37.50%	3 Missing and 2 partials ⚠️
...nts/UI/NetworkSelectorList/NetworkSelectorList.tsx	0.00%	2 Missing ⚠️
...nents/UI/PermissionsSummary/PermissionsSummary.tsx	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11963      +/-   ##
==========================================
+ Coverage   54.65%   55.18%   +0.53%     
==========================================
  Files        1744     1760      +16     
  Lines       39333    39795     +462     
  Branches     4878     4965      +87     
==========================================
+ Hits        21497    21962     +465     
+ Misses      16340    16318      -22     
- Partials     1496     1515      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-10-24T13:57:17Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 97d3f43
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3aaa6371-5258-4659-a9cb-fe720d10239a

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2024-10-30T19:52:41Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1b398cb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/118920fa-11ae-47e4-9d71-7ef16590fb4c

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…ompare

github-actions · 2024-10-31T13:34:24Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 161a924
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/32eed85f-8382-4ee1-ab12-5d106cf6bc4f

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

…st week, but the revoking should be done in the next step of the navigation flow, REVOKE_ALL_ACCOUNT_PERMISSIONS. This is now fixed.

github-actions · 2024-10-31T14:48:52Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 17c0f11
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2d6f20f6-72bc-45a8-925f-e1e77dfe555b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

app/components/Views/AccountConnect/AccountConnect.tsx

vinnyhoward

Looks great to me! Excited to see this feature in prod🔥

app/components/UI/NetworkVerificationInfo/NetworkVerificationInfo.tsx

app/components/Views/AccountConnect/AccountConnect.tsx

github-actions · 2024-11-01T13:33:37Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 86c857c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/76d03983-81ad-462e-addb-d59f463d8da2

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarqubecloud · 2024-11-01T13:43:58Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

adonesky1 and others added 5 commits October 21, 2024 09:39

next steps for integration

8f2c5cf

Merge branch 'main' into ad/poc

5766943

feat: the network name was not showing, this is now fixed

22259bd

feat: display the network image in the list of network permissions th…

2142554

…at can be selected

fix: display the dapp origin only when it's specific to a dapp, since…

9ed8230

… in some case this modal is displayed when switching from the global selector

EtherWizard33 added No QA Needed Apply this label when your PR does not need any QA effort. team-wallet-ux labels Oct 22, 2024

EtherWizard33 added 3 commits October 22, 2024 16:43

style: lint

697492a

fix: just check the dapp origin, previous commit of the PR was changi…

d6d4453

…ng more than needed and it made the snapshot fail, TY snapshots.

feat: wire up the network avatar group to show permitted networks dur…

9087c64

…ing the connected flow

EtherWizard33 changed the title ~~feat(2808): edit network happy path~~ feat(2808): edit network permissions Oct 23, 2024

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 23, 2024

test: update snapshot after having wired up the network permission's …

850e31d

…avatar group

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024

feat: initial connection flow can now edit networks

8c6d4be

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024

chore: update the exclusions, until next week, we are starting unit t…

97d3f43

…est on new code

EtherWizard33 added team-wallet-ux Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Oct 24, 2024

EtherWizard33 added 2 commits October 31, 2024 09:26

style: refactor for sonar, ternary operators should not be nested

ffed0c2

style: refactor for sonar, should use a compare function with localeC…

161a924

…ompare

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024

EtherWizard33 added 2 commits October 31, 2024 09:45

fix: the revoking from this onPress had been added from another PR la…

7d50ebd

…st week, but the revoking should be done in the next step of the navigation flow, REVOKE_ALL_ACCOUNT_PERMISSIONS. This is now fixed.

style: lint

17c0f11

EtherWizard33 removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 31, 2024

EtherWizard33 marked this pull request as ready for review October 31, 2024 14:48

EtherWizard33 requested review from a team as code owners October 31, 2024 14:48

EtherWizard33 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 31, 2024

vinnyhoward reviewed Oct 31, 2024

View reviewed changes

app/components/Views/AccountConnect/AccountConnect.tsx Show resolved Hide resolved

vinnyhoward approved these changes Oct 31, 2024

View reviewed changes

Merge branch 'main' into feat-2808-edit-network-happy-path

88978c0

tommasini approved these changes Nov 1, 2024

View reviewed changes

app/components/UI/NetworkVerificationInfo/NetworkVerificationInfo.tsx Show resolved Hide resolved

app/components/Views/AccountConnect/AccountConnect.tsx Show resolved Hide resolved

Merge branch 'main' into feat-2808-edit-network-happy-path

86c857c

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 1, 2024

EtherWizard33 enabled auto-merge November 1, 2024 13:36

EtherWizard33 added this pull request to the merge queue Nov 1, 2024

Merged via the queue into main with commit b8061aa Nov 1, 2024
42 of 43 checks passed

EtherWizard33 deleted the feat-2808-edit-network-happy-path branch November 1, 2024 14:00

github-actions bot locked and limited conversation to collaborators Nov 1, 2024

metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(2808): edit network permissions #11963

feat(2808): edit network permissions #11963

EtherWizard33 commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 23, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 23, 2024 •

edited by metamaskbot

Loading

codecov-commenter commented Oct 23, 2024

github-actions bot commented Oct 24, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 30, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

vinnyhoward left a comment

github-actions bot commented Nov 1, 2024 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Nov 1, 2024

feat(2808): edit network permissions #11963

feat(2808): edit network permissions #11963

Conversation

EtherWizard33 commented Oct 22, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 23, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 23, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 23, 2024 • edited by metamaskbot Loading

Bitrise

codecov-commenter commented Oct 23, 2024

Codecov Report

github-actions bot commented Oct 24, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 30, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 31, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 31, 2024 • edited by metamaskbot Loading

Bitrise

vinnyhoward left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 1, 2024 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Nov 1, 2024

Quality Gate passed

EtherWizard33 commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 23, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 23, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 23, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 24, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 30, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 31, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 1, 2024 •

edited by metamaskbot

Loading