Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STAKE-803 integrate unstake method from sdk #11962

Merged
merged 8 commits into from
Oct 24, 2024

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Oct 22, 2024

Description

This PR adds the ability to unstake natively within the MetaMask mobile app.

Related issues

Jira Ticket: [FE] [Unstake flow] Integrate unstake method from sdk - (link)

Manual testing steps

prerequisite: if you don't have any Ethereum staked, you'll need to stake some in order to unstake.

  1. Add export MM_POOLED_STAKING_UI_ENABLED=true to .js.env file.
  2. Click on Ethereum from the asset list page
  3. Click on "Unstake"
  4. Enter a valid amount to unstake and click "Review"
  5. Click "Continue" to initiate the transaction-controller flow.

Figma Designs

Screenshots/Recordings

Before

stake-841-build-unstake-review-confirmation-screen-after.mov

After

stake-803-unstake-method-demo-after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 changed the title Feat/stake 803 integrate unstake method from sdk DO NOT MERGE: feat/STAKE-803 integrate unstake method from sdk Oct 22, 2024
@Matt561 Matt561 changed the title DO NOT MERGE: feat/STAKE-803 integrate unstake method from sdk feat/STAKE-803 integrate unstake method from sdk Oct 23, 2024
@Matt561 Matt561 changed the title feat/STAKE-803 integrate unstake method from sdk feat: STAKE-803 integrate unstake method from sdk Oct 23, 2024
@Matt561 Matt561 force-pushed the feat/stake-803-integrate-unstake-method-from-sdk branch from 9c7954d to 243ce0c Compare October 23, 2024 22:05
@Matt561 Matt561 marked this pull request as ready for review October 23, 2024 22:22
@Matt561 Matt561 requested a review from a team as a code owner October 23, 2024 22:22
@Matt561 Matt561 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9c98943
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9d6d497c-944a-4f08-af2c-83b77259086b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 24, 2024
Copy link
Contributor

github-actions bot commented Oct 24, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 01fe4a2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c4044dbb-d080-4090-91f3-5b264314ec01

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question and suggestion but otherwise good to go!

@Matt561 Matt561 requested a review from amitabh94 October 24, 2024 16:06
Copy link

Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matt561 Matt561 added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit e721d23 Oct 24, 2024
36 of 37 checks passed
@Matt561 Matt561 deleted the feat/stake-803-integrate-unstake-method-from-sdk branch October 24, 2024 17:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants