-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: STAKE-803 integrate unstake method from sdk #11962
feat: STAKE-803 integrate unstake method from sdk #11962
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
9c7954d
to
243ce0c
Compare
Bitrise❌❌❌ Commit hash: 9c98943 Note
Tip
|
Bitrise✅✅✅ Commit hash: 01fe4a2 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question and suggestion but otherwise good to go!
...mponents/StakingConfirmation/ConfirmationFooter/FooterButtonGroup/FooterButtonGroup.test.tsx
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR adds the ability to unstake natively within the MetaMask mobile app.
Related issues
Jira Ticket: [FE] [Unstake flow] Integrate unstake method from sdk - (link)
Manual testing steps
prerequisite: if you don't have any Ethereum staked, you'll need to stake some in order to unstake.
export MM_POOLED_STAKING_UI_ENABLED=true
to.js.env
file.Figma Designs
Screenshots/Recordings
Before
stake-841-build-unstake-review-confirmation-screen-after.mov
After
stake-803-unstake-method-demo-after.mov
Pre-merge author checklist
Pre-merge reviewer checklist