-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update default search engine to google #11958
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
Bitrise✅✅✅ Commit hash: 8d5e6a1 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled it down and works great, PR looks good as well. But I did encounter an issue where DDG would persist. I had to delete the app or the changes won't take hold.
The settings reducer needs to run through a migration on upgrade to update the default search engine property.
|
Bitrise❌❌❌ Commit hash: 34fb849 Note
Tip
|
Hey @vinnyhoward would you mind pulling in my changes and re-trying? I've added a migration script. |
Quality Gate passedIssues Measures |
Bitrise❌❌❌ Commit hash: d08db0e Note
Tip
|
Failures on Bitrise not related to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled down and tested. LGTM✅
Description
We have received several reports of phishing links being the top result within DuckDuckGo's search engine when searching for official web3 sites. This is a security risk to users and creates a poor user experience if the user cannot trust the search results.
See example here. (first result is a phishing link, shown above the official Uniswap.org website)
Switch the default search engine to Google, which shows more reliable results.
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist