Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default search engine to google #11958

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

mindofmar
Copy link
Contributor

@mindofmar mindofmar commented Oct 22, 2024

Description

  1. What is the reason for the change?

We have received several reports of phishing links being the top result within DuckDuckGo's search engine when searching for official web3 sites. This is a security risk to users and creates a poor user experience if the user cannot trust the search results.

See example here. (first result is a phishing link, shown above the official Uniswap.org website)

  1. What is the improvement/solution?

Switch the default search engine to Google, which shows more reliable results.

Manual testing steps

  1. Go to the Explore tab
  2. Run a search query using the mobile browser
  3. Ensure that the Browser searches on Google instead of DuckDuckGo

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-product-safety Push issues to Product Safety team label Oct 22, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 22, 2024
@mindofmar
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@mindofmar mindofmar changed the title update default search engine to google fix: update default search engine to google Oct 22, 2024
@mindofmar mindofmar added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 25, 2024
Copy link
Contributor

github-actions bot commented Oct 25, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8d5e6a1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f890c631-722b-4247-a31e-d5a4be81df65

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@mindofmar mindofmar marked this pull request as ready for review October 25, 2024 16:22
@mindofmar mindofmar requested review from a team as code owners October 25, 2024 16:22
vinnyhoward
vinnyhoward approved these changes Oct 25, 2024
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled it down and works great, PR looks good as well. But I did encounter an issue where DDG would persist. I had to delete the app or the changes won't take hold.

@sethkfman
Copy link
Contributor

sethkfman commented Oct 25, 2024

The settings reducer needs to run through a migration on upgrade to update the default search engine property.

@mindofmar mindofmar added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 30, 2024
@mindofmar mindofmar added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 34fb849
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50a4e1c5-7b6d-480d-96b2-2ec1cdfd7578

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@mindofmar
Copy link
Contributor Author

Hey @vinnyhoward would you mind pulling in my changes and re-trying? I've added a migration script.

Copy link

@mindofmar mindofmar added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d08db0e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8c9f0a5e-38a4-4f5e-a881-0c77edeb0a2a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Cal-L
Copy link
Contributor

Cal-L commented Oct 31, 2024

Failures on Bitrise not related to this PR

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down and tested. LGTM✅

@mindofmar mindofmar added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 27d0ba8 Nov 1, 2024
44 of 45 checks passed
@mindofmar mindofmar deleted the fix/default-to-google-search branch November 1, 2024 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-product-safety Push issues to Product Safety team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants