-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1940 add custom sentry span #11935
Conversation
…/MetaMask/metamask-mobile into feat/1940-add-custom-sentry-span
…/MetaMask/metamask-mobile into feat/1940-add-custom-sentry-span
…/MetaMask/metamask-mobile into feat/1940-add-custom-sentry-span
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: f6adb4c Note
|
Bitrise✅✅✅ Commit hash: b69ed01 Note
|
Bitrise❌❌❌ Commit hash: a7c2540 Note
Tip
|
Bitrise✅✅✅ Commit hash: 1a93300 Note
|
Bitrise✅✅✅ Commit hash: 9f00e41 Note
|
Quality Gate passedIssues Measures |
Description
This task is for adding custom spans to track activities that happen between app start and wallet UI load. The screenshot below is an example of a trace for Wallet UI load that takes about a minute to load. During that time, we can see a large gap between app start spans and the initial http requests.
The goal here is to isolate these areas and track them with custom spans. Once implemented, we can expect to see the custom spans appearing within the gap, which would inform us of the areas to optimize
Issue: https://github.com/MetaMask/mobile-planning/issues/1940
Technical Details
##Engine Initialisation Bug##
While initally the engine init trace was preceded by an await, which would allow the grouping of all the calls that happen inside Engine to be under the Engine Initialisation process, that would cause a crash of the application in Production on Android.
As a temporary fix until the issue that happens within Engine is found and fixed, the only noticeable difference will take place as bellow. API calls from within the Engine Initialization, will not all be grouped within the same span.
(left without await, right with await)
Bitrise Build: https://app.bitrise.io/build/6ee0b625-d8b9-4d95-9fcc-a1d624202736?tab=artifacts
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist