Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1940 add custom sentry span #11935

Merged
merged 31 commits into from
Oct 23, 2024
Merged

Conversation

MarioAslau
Copy link
Contributor

@MarioAslau MarioAslau commented Oct 22, 2024

Description

Screenshot 2024-10-11 at 20 29 04 Screenshot 2024-10-16 at 00 01 02 Screenshot 2024-10-15 at 17 57 12

This task is for adding custom spans to track activities that happen between app start and wallet UI load. The screenshot below is an example of a trace for Wallet UI load that takes about a minute to load. During that time, we can see a large gap between app start spans and the initial http requests.

The goal here is to isolate these areas and track them with custom spans. Once implemented, we can expect to see the custom spans appearing within the gap, which would inform us of the areas to optimize

Issue: https://github.com/MetaMask/mobile-planning/issues/1940

Technical Details

  • Added custom span for when the Login screen is mounted to when the login button is tapped
  • Added span for when the login button is tapped to when the wallet view is mounted
  • Added custom span for Engine initialization process
  • Added custom span for Store creation
  • Added custom span Storage rehydration
  • Added custom span fro Create New Wallet to Choose Password
  • Added custom span for Biometrics authentication

##Engine Initialisation Bug##

While initally the engine init trace was preceded by an await, which would allow the grouping of all the calls that happen inside Engine to be under the Engine Initialisation process, that would cause a crash of the application in Production on Android.

As a temporary fix until the issue that happens within Engine is found and fixed, the only noticeable difference will take place as bellow. API calls from within the Engine Initialization, will not all be grouped within the same span.
Screenshot 2024-10-22 at 05 02 54

(left without await, right with await)

Bitrise Build: https://app.bitrise.io/build/6ee0b625-d8b9-4d95-9fcc-a1d624202736?tab=artifacts

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@MarioAslau MarioAslau self-assigned this Oct 22, 2024
@MarioAslau MarioAslau marked this pull request as ready for review October 22, 2024 09:26
@MarioAslau MarioAslau requested review from a team as code owners October 22, 2024 09:26
@MarioAslau MarioAslau added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise team-tiger Tiger team (for tech debt reduction + performance improvements) labels Oct 22, 2024
@MarioAslau MarioAslau requested a review from sethkfman October 22, 2024 09:26
@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f6adb4c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/53fd2edf-205b-4ee3-8cf1-b087c25df4ea

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b69ed01
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/214d60e9-6c94-46a7-8e2a-068989ee0755

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a7c2540
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9284d684-99cd-448d-924f-b9fbcb86d077

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1a93300
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4a264b9c-c7bd-4c1e-a966-19f9d0adf482

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MarioAslau MarioAslau added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f00e41
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/94e08554-dc69-4db0-8303-9d0081d50169

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@tommasini tommasini enabled auto-merge October 23, 2024 15:24
@tommasini tommasini added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 3b21958 Oct 23, 2024
43 checks passed
@tommasini tommasini deleted the feat/1940-add-custom-sentry-span branch October 23, 2024 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants