Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade signature controller to remove message managers #11911

Merged
merged 6 commits into from
Oct 23, 2024
Merged

chore: upgrade signature controller to remove message managers #11911

merged 6 commits into from
Oct 23, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Oct 21, 2024 •
edited
Loading

Description

Upgrade @metamask/signature-controller to version 20.1.0 to remove all usage of metamask/message-managers.

Upgrade @metamask/approval-controller to version 7.1.0 and remove the unnecessary patch.

Upgrade Node version from 20.12.2 to 20.14.0.

Related issues

Manual testing steps

Full regression of all signature functionality.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Oct 21, 2024
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners October 21, 2024 12:22
@matthewwalsh0 matthewwalsh0 mentioned this pull request Oct 21, 2024
Merged
4 tasks
@socket-security Socket Security
Copy link

socket-security bot commented Oct 21, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/approval-controller@7.1.0 None 0 0 B
npm/@metamask/signature-controller@20.1.0 None +1 377 kB metamaskbot

🚮 Removed packages: npm/@metamask/approval-controller@7.0.2, npm/@metamask/signature-controller@19.1.0

View full report↗︎

@matthewwalsh0 matthewwalsh0 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9804e17
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1e21e08a-719a-4e02-be60-39adce59710e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

jpuri
jpuri previously approved these changes Oct 21, 2024
View reviewed changes
@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Oct 22, 2024
@sleepytanya
Copy link
Contributor

Bitrise builds:
https://app.bitrise.io/build/550882dd-7e49-4477-a3ba-890eca343e8d?tab=artifacts
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2bf54b64-5321-4402-81fa-c08b126a1d27

All Signatures function as expected on Android and iOS devices.

iosSign.mp4
androidSign.mp4

@matthewwalsh0
Use real package version
62329b3 
Update Node version.
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6117655
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/73d02d87-af85-43ff-b642-7f58d473f4b0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 23, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4517054
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a0132bf-cbcf-467b-9760-094072ea879b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini reviewed Oct 23, 2024
View reviewed changes
.nvmrc Show resolved Hide resolved
tommasini
tommasini approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit d6c52fe Oct 23, 2024
43 checks passed
@matthewwalsh0 matthewwalsh0 deleted the chore/bump-signature-controller-no-message-managers branch October 23, 2024 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 23, 2024
legobeat
legobeat reviewed Oct 23, 2024
View reviewed changes
.nvmrc
@@ -1 +1 @@
20.12.2
20.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewwalsh0 Any reason to hold at 20.14.0? Would be great if we can bump to at minimum 20.17 of not 20.18:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doing the minimum bump to satisfy the latest version of eth-sig-util which needs ^20.14.

Anything beyond that is also fine of course.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@legobeat legobeat legobeat left review comments

@tommasini tommasini tommasini approved these changes

@vinistevam vinistevam vinistevam approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@jpuri jpuri jpuri left review comments

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@matthewwalsh0 @sleepytanya @jpuri @pedronfigueiredo @vinistevam @tommasini @legobeat @metamaskbot