Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: ENS links #1187

Merged
merged 7 commits into from
Nov 12, 2019
Merged

Bugfix: ENS links #1187

merged 7 commits into from
Nov 12, 2019

Conversation

brunobar79
Copy link
Contributor

@brunobar79 brunobar79 commented Nov 11, 2019

Fixes #1185

Also fixes the crash for domains that can't be resolved to an IPFS hash, for ex. tesla.eth

@brunobar79 brunobar79 added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Nov 11, 2019
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on both OS's, QA passed 👍

@brunobar79 brunobar79 merged commit e2e4a7c into develop Nov 12, 2019
@brunobar79 brunobar79 deleted the fix-ens-links branch November 12, 2019 00:28
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* fix ens links

* clean up

* clean up

* dont crash with unsupported .eth urls

* fix android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Any New Features that needs a full manual QA prior to being added to a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENS => IPFS not working properly when navigating from a link
3 participants