Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade assets controllers v34.0.0 #11860

Merged
merged 7 commits into from
Oct 18, 2024
Merged

chore: upgrade assets controllers v34.0.0 #11860

merged 7 commits into from
Oct 18, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Oct 18, 2024 •
edited
Loading

Description

Update assets-controllers to v34.0.0

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2024-10-18.at.13.10.51.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri changed the title Chore/upgrade assets controllers v34.0.0 chore: upgrade assets controllers v34.0.0 Oct 18, 2024
@sahar-fehri sahar-fehri added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Oct 18, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Oct 18, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@34.0.0 None +3 2.44 MB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@33.0.0

View full report↗︎

@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d5c3efb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3cb1d600-25d3-46c6-a1d3-c2d7d6376ffd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fc80bd2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/16e53edb-3a53-4718-9421-041095a01f58

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review October 18, 2024 11:08
@sahar-fehri sahar-fehri requested review from a team as code owners October 18, 2024 11:08
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7faf675
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b654ec1b-3d32-40a3-a55a-d2b4700a4110

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cryptodev-2s
cryptodev-2s approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Great work!

@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit c74bb78 Oct 18, 2024
45 checks passed
@sahar-fehri sahar-fehri deleted the chore/upgrade-assets-controllers-v34.0.0 branch October 18, 2024 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sahar-fehri @tommasini @cryptodev-2s @metamaskbot