Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: STAKE-805 integrate stake method #11845

Merged
merged 18 commits into from
Oct 22, 2024

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Oct 17, 2024

Description

This PR enables staking on both Ethereum mainnet and Holesky.

Related issues

Ticket: STAKE-805: [FE] [Stake flow] Integrate stake sdk method

Manual testing steps

  1. Add export MM_POOLED_STAKING_UI_ENABLED=true to your .js.env file.
  2. Select Ethereum in the asset list
  3. Scroll down a bit and click "Stake More"
  4. Enter an amount to stake and click "review"
  5. On the review screen, click "Continue"
  6. You should see the transaction confirmation screen appear. Click "Confirm".
  7. The transaction should be submitted and you should be redirected to the Ethereum asset details page

Screenshots/Recordings

Before

stake-824-build-stake-confirmation-screen-after.mov

After

Update: On transaction submission, the user is now redirected to the Transactions View.

stake-805-stake-method-demo-after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/stake-sdk@0.2.13 network 0 165 kB metamaskbot

🚮 Removed packages: npm/@metamask/stake-sdk@0.2.11

View full report↗︎

@Matt561 Matt561 force-pushed the feat/stake-805-integrate-stake-method branch 2 times, most recently from 1b2bdde to d2dd75c Compare October 17, 2024 17:19
@Matt561 Matt561 force-pushed the feat/stake-805-integrate-stake-method branch from d2dd75c to 0e39aea Compare October 18, 2024 14:36
@Matt561 Matt561 force-pushed the feat/stake-805-integrate-stake-method branch from 0e1ca74 to 4e41ad3 Compare October 18, 2024 20:32
@Matt561 Matt561 force-pushed the feat/stake-805-integrate-stake-method branch from 4e41ad3 to 66b8f8c Compare October 18, 2024 20:33
Copy link

socket-security bot commented Oct 18, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/stake-sdk@0.2.13

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@Matt561 Matt561 marked this pull request as ready for review October 18, 2024 20:36
@Matt561 Matt561 requested review from a team as code owners October 18, 2024 20:36
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments but LGTM! Great job on this !

@Matt561 Matt561 force-pushed the feat/stake-805-integrate-stake-method branch from dcd240b to 78dafc2 Compare October 21, 2024 14:09
@Matt561 Matt561 force-pushed the feat/stake-805-integrate-stake-method branch from e982dbb to 51faab0 Compare October 21, 2024 17:56
amitabh94
amitabh94 previously approved these changes Oct 21, 2024
@Matt561 Matt561 force-pushed the feat/stake-805-integrate-stake-method branch from 51faab0 to e456aba Compare October 21, 2024 21:14
@Matt561 Matt561 requested a review from amitabh94 October 21, 2024 21:14
amitabh94
amitabh94 previously approved these changes Oct 21, 2024
@amitabh94
Copy link
Contributor

@SocketSecurity ignore-all

@metamask/Stake-sdk uses fetch to communicate with staking backend api service

@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e456aba
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/80f0b695-883b-4c72-ad90-dc75c324d69f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Matt561 Matt561 requested a review from amitabh94 October 21, 2024 21:53
@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9902f6c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fac9ceda-aa89-46c5-b620-80f2302c87f3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for you work and sorry for the delay on review.

@Matt561 Matt561 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit f2f84ed Oct 22, 2024
37 checks passed
@Matt561 Matt561 deleted the feat/stake-805-integrate-stake-method branch October 22, 2024 15:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants