-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: STAKE-805 integrate stake method #11845
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/stake-sdk@0.2.11 |
1b2bdde
to
d2dd75c
Compare
d2dd75c
to
0e39aea
Compare
0e1ca74
to
4e41ad3
Compare
4e41ad3
to
66b8f8c
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very minor comments but LGTM! Great job on this !
...ke/components/StakingConfirmation/ConfirmationFooter/FooterButtonGroup/FooterButtonGroup.tsx
Show resolved
Hide resolved
dcd240b
to
78dafc2
Compare
e982dbb
to
51faab0
Compare
51faab0
to
e456aba
Compare
@SocketSecurity ignore-all @metamask/Stake-sdk uses fetch to communicate with staking backend api service |
Bitrise✅✅✅ Commit hash: e456aba Note
|
Bitrise✅✅✅ Commit hash: 9902f6c Note
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for you work and sorry for the delay on review.
Description
This PR enables staking on both Ethereum mainnet and Holesky.
Related issues
Ticket: STAKE-805: [FE] [Stake flow] Integrate stake sdk method
Manual testing steps
export MM_POOLED_STAKING_UI_ENABLED=true
to your .js.env file.Screenshots/Recordings
Before
stake-824-build-stake-confirmation-screen-after.mov
After
Update: On transaction submission, the user is now redirected to the Transactions View.
stake-805-stake-method-demo-after.mov
Pre-merge author checklist
Pre-merge reviewer checklist