Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert custom span #11839

Merged
merged 2 commits into from
Oct 17, 2024
Merged

chore: Revert custom span #11839

merged 2 commits into from
Oct 17, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Oct 17, 2024

Description

Revert this PR

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 17, 2024
@tommasini tommasini requested review from a team as code owners October 17, 2024 15:06
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@tommasini tommasini changed the title Revert/custom span commit chore: Revert custom span Oct 17, 2024
Copy link

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit 392f8d0 into release/7.33.0 Oct 17, 2024
40 of 41 checks passed
@sethkfman sethkfman deleted the revert/custom-span-commit branch October 17, 2024 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants