Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid wallet connect detection (wrong hostname in connect modal) #11834

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix: invalid wallet connect detection (wrong hostname in connect modal) #11834

merged 2 commits into from
Oct 17, 2024
+2 −1

Conversation

abretonc7s
Copy link
Contributor

@abretonc7s abretonc7s commented Oct 17, 2024 •
edited
Loading

Description

Related issues

Fixes: https://consensyssoftware.atlassian.net/jira/software/projects/SDK/boards/711?selectedIssue=SDK-98&sprintStarted=true

Manual testing steps

  1. Check that url is set correctly for sdk / walllet connect / in-appbrowser
  2. Check also on related rpc calls (sign request / wallet requestpermissions etc)

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-sdk SDK team label Oct 17, 2024
@abretonc7s abretonc7s self-assigned this Oct 17, 2024
@abretonc7s abretonc7s added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Oct 17, 2024
@abretonc7s abretonc7s marked this pull request as ready for review October 17, 2024 07:54
@abretonc7s abretonc7s requested a review from a team as a code owner October 17, 2024 07:54
elefantel
elefantel approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@elefantel elefantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherferreira9 christopherferreira9 added Run Smoke E2E Triggers smoke e2e on Bitrise QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: d7358f7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ef021b05-c50e-4d40-8c04-a65dc17d577a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@christopherferreira9 christopherferreira9 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 11f6645
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c266e581-65b1-4e52-84a6-ac2aa835c027

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@christopherferreira9 christopherferreira9 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit abada14 Oct 17, 2024
41 of 43 checks passed
@christopherferreira9 christopherferreira9 deleted the invalidconnect branch October 17, 2024 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elefantel elefantel elefantel approved these changes

Assignees

@abretonc7s abretonc7s

Labels
QA in Progress QA has started on the feature. release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-sdk SDK team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abretonc7s @elefantel @metamaskbot @christopherferreira9