Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix create qa build pipeline #11825

Merged
merged 6 commits into from
Oct 16, 2024
Merged

chore: fix create qa build pipeline #11825

merged 6 commits into from
Oct 16, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Oct 16, 2024

Description

This PR aims to address the issue of creating the iOS QA variant in release mode. The missing flipper flag in the bitrise script caused the iOS build to fail. The flag was readded. Furthermore, a retry was added to the iOS api specs script.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Passing Create QA pipeline: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b71f68a-2a3e-4aed-bfdd-55e8042ac5f8

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 16, 2024
@cortisiko cortisiko self-assigned this Oct 16, 2024
@cortisiko cortisiko requested review from a team as code owners October 16, 2024 18:38
@cortisiko cortisiko linked an issue Oct 16, 2024 that may be closed by this pull request
9 tasks
Copy link
Contributor

github-actions bot commented Oct 16, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b35e703
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/de3bbf9c-5e9c-4541-87f7-6da4109dabdd

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cortisiko cortisiko added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 0482c6e Oct 16, 2024
52 checks passed
@cortisiko cortisiko deleted the fix-qa-build-pipeline branch October 16, 2024 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create_QA_builds_pipeline failing on build_ios_qa
3 participants