Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Gravity network icon #11803

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Conversation

gambinish
Copy link
Contributor

Description

Adds Gravity Network logo as custom network

https://chainlist.org/chain/1625

Related issues

Fixes: No issue created

Manual testing steps

  1. Add Gravity as custom network
  2. Custom network should appear as network logo (see screenshots)

Screenshots/Recordings

Screenshot 2024-10-15 at 7 45 46 AM Screenshot 2024-10-15 at 7 46 08 AM Screenshot 2024-10-15 at 7 46 27 AM Screenshot 2024-10-15 at 7 46 41 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish requested a review from a team October 15, 2024 17:52
@gambinish gambinish added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 02300c6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/27210eac-6abc-485a-afed-13579a0bc679

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@gambinish gambinish marked this pull request as ready for review October 15, 2024 18:00
@gambinish gambinish requested a review from a team as a code owner October 15, 2024 18:00
sahar-fehri
sahar-fehri previously approved these changes Oct 17, 2024
@gambinish gambinish enabled auto-merge October 17, 2024 21:25
@gambinish gambinish added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 024d973
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/83d26374-1e68-495e-8f98-faf17f71db63

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@gambinish gambinish added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 3bcadc2 Oct 22, 2024
37 checks passed
@gambinish gambinish deleted the chore/add-gravity-network-icon branch October 22, 2024 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants