Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persist token and phishing list #11802

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Oct 15, 2024

Description

Persisting back again token list and phishing list.

From 11KBs to 8MB to an wallet with:

  • 2 accounts
  • 7 Networks added plus Ethereum and LInea Mainnet
    Tokens imported by network
    • Ethereum: 16
    • Linea: 6
    • Avalanche: 9
    • Binance: 10
    • Base: 1
    • Optimism: 3
    • Polygon: 3
    • Palm:0
    • ZkSync: 1
    • Arbitrum: 5

App launch times e2e:
1- https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b1ae0ba0-cee8-472d-978e-17882f132740
2- https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d8fda877-0c9a-4448-a75a-cc4921551e16
3- https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/38dc5140-e18e-494c-a86a-22492554e837

------After fixing e2e------
1- https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/797b8317-6116-4bb5-8a12-e60a8e1b7aeb

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Exploring app (tokens):
https://github.com/user-attachments/assets/638e42de-2219-423f-a9ee-6b18ada57751

Phishing detector in app browser:
https://github.com/user-attachments/assets/62f63451-fa7e-445f-b875-21155b13a8bc

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise team-tiger Tiger team (for tech debt reduction + performance improvements) labels Oct 15, 2024
@tommasini tommasini requested a review from a team as a code owner October 15, 2024 17:46
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Oct 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 148c161
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/605e173a-75a4-436d-a2e8-c8007c5b11f1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

MarioAslau
MarioAslau previously approved these changes Oct 15, 2024
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added this pull request to the merge queue Oct 15, 2024
@sethkfman sethkfman removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 15, 2024
Merged via the queue into main with commit 9db29fd Oct 15, 2024
41 of 42 checks passed
@tommasini tommasini deleted the fix/persisting-token-phishing-list branch October 15, 2024 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2024
@sethkfman sethkfman added release-7.33.0 Issue or pull request that will be included in release 7.33.0 and removed release-7.34.0 labels Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants