Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade assets controllers v33.0.0 #11800

Merged
merged 9 commits into from
Oct 18, 2024
Merged

chore: upgrade assets controllers v33.0.0 #11800

merged 9 commits into from
Oct 18, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Oct 15, 2024 •
edited
Loading

Description

PR to upgrade assets-controllers to v33.0.0

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2024-10-16.at.11.11.34.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 15, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Oct 15, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@33.0.0 None +3 2.43 MB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@32.0.0

View full report↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9200e03
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7989279e-b38b-4cb0-9832-9eb305c0c010

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review October 15, 2024 17:25
@sahar-fehri sahar-fehri requested review from a team as code owners October 15, 2024 17:25
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 36f889b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/44d473d0-06e0-41cb-9be2-a1c4dcae6e08

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Daniel-Cross
Copy link
Contributor

Hi @sahar-fehri

When I checkout the branch and cold boot the app I get stuck on a loading screen, see attached:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-16.at.11.21.07.mp4

Daniel-Cross
Daniel-Cross requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Daniel-Cross Daniel-Cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App gets stuck on loading screen on cold boot.

@Daniel-Cross
Copy link
Contributor

Hi @sahar-fehri

When I checkout the branch and cold boot the app I get stuck on a loading screen, see attached:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-16.at.11.21.07.mp4

This is addressed with a clean build of the app so I'll approve.

@Daniel-Cross Daniel-Cross self-requested a review October 16, 2024 09:29
Daniel-Cross
Daniel-Cross approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Daniel-Cross Daniel-Cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sahar-fehri
Copy link
Contributor Author

Thanks @Daniel-Cross for pulling the branch locally and testing it 🙏

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2edb087
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5f8b6866-d2d5-4c45-8742-db25d297da86

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 17, 2024
@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 17, 2024
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bbaf454
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/78cc12b9-3da4-4790-9a53-9211d535663c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ad0f014
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50e96fbe-2edb-4fe4-a787-d96abe68242a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

bergeron
bergeron approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@bergeron bergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked okay to me. Tested the usual features of token/nft detection, importing, removing, prices.

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7fbe0a6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/93adfe54-ccc2-41a7-8133-eabc20933aa6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit d663101 Oct 18, 2024
43 checks passed
@sahar-fehri sahar-fehri deleted the chore/upgrade-assets-controllers-v33.0.0-v2 branch October 18, 2024 05:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Daniel-Cross Daniel-Cross Daniel-Cross approved these changes

@bergeron bergeron bergeron approved these changes

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sahar-fehri @Daniel-Cross @bergeron @metamaskbot