-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable Security Alerts API #11770
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
32fbfce
to
cfbaf46
Compare
Bitrise✅✅✅ Commit hash: 74270bd Note
|
@vinistevam Just posting an update so you know what's happening!
1.mp42.mp43.mov
|
iOS build https://app.bitrise.io/app/be69d4368ee7e86d/installable-artifacts/612c067798c34679 Same PPOM functionality as on Android: BNB - Malicious Transfer (USDC) not flagged |
Bitrise✅✅✅ Commit hash: 28c22cb Note
|
Quality Gate passedIssues Measures |
Tests on ppom_main_bnb.webmzkSync: Malicious Permit and Malicious Seaport not flagged (Same as on my branch) ppom_zksync.webmTests on ppom_arbitrum_branch.webmSign Permit is not working on |
Description
This PR aims to enable the Security Alerts API. The environment variable
SECURITY_ALERTS_API_ENABLED
will be maintained and removed in a separate PR in a future release.There is a fallback mechanism that uses the local PPOM to validate the request in the case of an issue with the API. This safeguard is designed to prevent any disruption or impact on the user experience.
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/1878
Manual testing steps
Screenshots/Recordings
securty.alerts.api.webm
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist