Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix non regression tests #11768

Merged
merged 42 commits into from
Oct 22, 2024
Merged

fix: fix non regression tests #11768

merged 42 commits into from
Oct 22, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 13, 2024 •
edited
Loading

Description

This PR addresses multiple areas to improve the stability and maintainability of the project:

  1. Fix Non-Regression Tests
  2. Code Cleanup
  3. Increased Code Quality

Related issues

Fixes: #11892 #11893

Manual testing steps

  1. Run non regression test on this branch

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb self-assigned this Oct 13, 2024
@salimtb salimtb added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dbcee30
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4945c0d8-324e-4a33-b443-c160026e0e7f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb force-pushed the salim/fix-non-regression-tests branch from dbcee30 to 17636b4 Compare October 14, 2024 14:22
@salimtb salimtb removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 14, 2024
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8aec07a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7789bbce-e8ac-4e93-b91d-269225414a32

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ab9f10a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bd1553e0-97a2-47e6-88af-5c1ff9d6049d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb force-pushed the salim/fix-non-regression-tests branch from b8cfa3c to dc9d760 Compare October 16, 2024 08:50
@MetaMask MetaMask deleted a comment from sonarqubecloud bot Oct 16, 2024
@salimtb salimtb force-pushed the salim/fix-non-regression-tests branch from 1046370 to 2bb875d Compare October 16, 2024 14:22
@MetaMask MetaMask deleted a comment from sonarqubecloud bot Oct 20, 2024
@MetaMask MetaMask deleted a comment from codecov-commenter Oct 20, 2024
@salimtb salimtb force-pushed the salim/fix-non-regression-tests branch from 36bccd0 to 66f1f57 Compare October 20, 2024 18:08
@salimtb salimtb force-pushed the salim/fix-non-regression-tests branch from dc628ad to 5d8a421 Compare October 20, 2024 18:52
@salimtb salimtb force-pushed the salim/fix-non-regression-tests branch from 5d8a421 to e1a5844 Compare October 20, 2024 19:05
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 20, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e1a5844
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be40be6e-3460-4611-a032-ab6797afd6a6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fe8b868
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c230ec7a-a627-4202-8bc5-aaad99db7dcb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
62.7% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarCloud

andreahaku
andreahaku approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salimtb salimtb added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 014d65a Oct 22, 2024
37 checks passed
@salimtb salimtb deleted the salim/fix-non-regression-tests branch October 22, 2024 15:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

@andreahaku andreahaku andreahaku approved these changes

@tommasini tommasini tommasini left review comments

Assignees

@salimtb salimtb

Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to add alternate RPC URL manually on iPhone
5 participants
@salimtb @andreahaku @cortisiko @tommasini @metamaskbot