Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update setup docs and google-services-example.json #11758

Merged
merged 4 commits into from
Oct 23, 2024
Merged

chore: update setup docs and google-services-example.json #11758

merged 4 commits into from
Oct 23, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 11, 2024 •
edited
Loading

Description

  • add flask and qa entries to google-services-example.json
  • add generated file to .gitignore
  • docs: no wrap base64 output
  • docs: update README.md with GOOGLE_SERVICES_B64 docs

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat marked this pull request as ready for review October 11, 2024 13:26
@legobeat legobeat requested a review from a team as a code owner October 11, 2024 13:26
@legobeat legobeat added team-security No E2E Smoke Needed If the PR does not need E2E smoke test run skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. area-documentation labels Oct 11, 2024
@legobeat legobeat force-pushed the local-setup-docs branch 3 times, most recently from 6a3480d to dcba1c6 Compare October 14, 2024 09:20
@legobeat legobeat requested review from tommasini and leotm October 14, 2024 09:40
@legobeat legobeat mentioned this pull request Oct 14, 2024
Merged
7 tasks
@legobeat legobeat force-pushed the local-setup-docs branch 2 times, most recently from e73b798 to 7f162d1 Compare October 14, 2024 19:54
@legobeat legobeat requested a review from cortisiko October 14, 2024 20:00
@legobeat legobeat force-pushed the local-setup-docs branch 7 times, most recently from b2bac32 to a14c5ce Compare October 21, 2024 18:54
@legobeat legobeat force-pushed the local-setup-docs branch 2 times, most recently from dc40b6f to e8dbe06 Compare October 23, 2024 09:51
tommasini
tommasini approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COOL!

@legobeat
chore: add missing flask,qa entries to google-services-example.json
26ecd42 
Fix build error:

    Execution failed for task ':app:processFlaskDebugGoogleServices'.
    > No matching client found for package name 'io.metamask.flask' in /home/i/dev/mm/metamask-mobile/android/app/google-services.json
@legobeat
chore: add generated modules.json to gitignore
afb2da2
@legobeat
docs: no wrap base64 output
96b7683
@legobeat legobeat enabled auto-merge October 23, 2024 12:58
@legobeat legobeat added this pull request to the merge queue Oct 23, 2024
Merged via the queue into MetaMask:main with commit dfb411f Oct 23, 2024
36 of 37 checks passed
@legobeat legobeat deleted the local-setup-docs branch October 23, 2024 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@leotm leotm Awaiting requested review from leotm

@cortisiko cortisiko Awaiting requested review from cortisiko

Assignees
No one assigned
Labels
area-documentation No E2E Smoke Needed If the PR does not need E2E smoke test run skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-security
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @tommasini