Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback originWhitelist #11741

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: rollback originWhitelist #11741

merged 1 commit into from
Oct 10, 2024

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR fix a bug where snaps execution webview opens blocking the app instead of being on background.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screen.Recording.2024-10-10.at.16.07.49.mov

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Oct 10, 2024
@Jonathansoufer Jonathansoufer requested a review from a team as a code owner October 10, 2024 15:29
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Oct 10, 2024
@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform No E2E Smoke Needed If the PR does not need E2E smoke test run and removed team-snaps-platform Snaps Platform team labels Oct 10, 2024
@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 10, 2024
@Jonathansoufer Jonathansoufer removed the No E2E Smoke Needed If the PR does not need E2E smoke test run label Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c65ebca
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9adfed00-e68c-4054-bbb0-5dd13690404a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@Jonathansoufer Jonathansoufer added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 43505e9 Oct 10, 2024
62 of 63 checks passed
@Jonathansoufer Jonathansoufer deleted the fix/webview-front-render branch October 10, 2024 16:27
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants