Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add references and utils for delete storage key #11733

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

Jonathansoufer
Copy link
Contributor

@Jonathansoufer Jonathansoufer commented Oct 10, 2024

Description

This PR implements a feature for our users get access to delete their Notification's storage keys if need.

Related issues

Fixes:

Manual testing steps

  1. Go to Settings
  2. Choose Notifications
  3. Make sure its enabled
  4. Click on Reset Notifications
  5. Proceed
  6. Check if Notifications remain enabled and a toast is shown.

Screenshots/Recordings

Before

After

Screen.Recording.2024-10-10.at.13.59.18.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer self-assigned this Oct 10, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners October 10, 2024 10:11
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Oct 10, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners October 10, 2024 13:04
Copy link

socket-security bot commented Oct 10, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/profile-sync-controller@0.9.7 network 0 1.11 MB metamaskbot

🚮 Removed packages: npm/@metamask/profile-sync-controller@0.9.5

View full report↗︎

@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9f36768
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9fb085f-6a0d-4d44-9f9b-5613d0c6e36a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@tommasini
Copy link
Contributor

Can you add manual steps to the PR description please? It will be easier to test on release that way!

@Jonathansoufer Jonathansoufer added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 10, 2024
@Jonathansoufer Jonathansoufer added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 4a2ceea Oct 10, 2024
45 checks passed
@Jonathansoufer Jonathansoufer deleted the feat/notifications-reset-storage-key branch October 10, 2024 18:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 10, 2024
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notifications team label Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-mobile-platform team-notifications Notifications team team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants