Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add safe space on the left of bell icon #11722

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR fix a small misalignment on the notifications icons on small devices.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

image (1)

After

Screenshot 2024-10-09 at 22 02 18

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer requested a review from a team as a code owner October 9, 2024 21:09
@Jonathansoufer Jonathansoufer self-assigned this Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Oct 9, 2024
@Jonathansoufer Jonathansoufer added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform No E2E Smoke Needed If the PR does not need E2E smoke test run and removed team-snaps-platform Snaps Platform team labels Oct 9, 2024
Copy link

sonarqubecloud bot commented Oct 9, 2024

@Jonathansoufer Jonathansoufer added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 64807c1 Oct 9, 2024
56 of 57 checks passed
@Jonathansoufer Jonathansoufer deleted the fix/android-notifications-bell-space branch October 9, 2024 21:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants