-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sentry): don't report AxiosError: Network Error
#11721
Conversation
…an error from axois when the request fails due to poor connection
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 5adfb0e Note
|
Bitrise❌❌❌ Commit hash: cb6d002 Note
Tip
|
Bitrise❌❌❌ Commit hash: 5384c97 Note
Tip
|
Hey @Daniel-Cross could you plz provide the best way for me to recreate the buggy behavior vs fix? Also may want to run Bitrise once more as it may have flaked. |
AxiosError: Network Error
Bitrise✅✅✅ Commit hash: 4604866 Note
|
Bitrise🔄🔄🔄 Commit hash: 856771f Note
|
Bitrise✅✅✅ Commit hash: 9427fc2 Note
|
Quality Gate passedIssues Measures |
Description
Added a try catch around the infura calls so Sentry does not pick up an error from axois when the request fails due to poor connection.
Related issues
Fixes: This issue
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist