Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sentry): don't report AxiosError: Network Error #11721

Merged
merged 36 commits into from
Oct 22, 2024

Conversation

Daniel-Cross
Copy link
Contributor

@Daniel-Cross Daniel-Cross commented Oct 9, 2024

Description

Added a try catch around the infura calls so Sentry does not pick up an error from axois when the request fails due to poor connection.

Related issues

Fixes: This issue

Manual testing steps

  • Open the app, log in, disconnect from the internet.
    • App should now handle that failure instead of the api throwing an error which is caught by Sentry.

Screenshots/Recordings

Before

Screenshot 2024-10-15 at 14 53 11

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…an error from axois when the request fails due to poor connection
@Daniel-Cross Daniel-Cross added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 9, 2024
@Daniel-Cross Daniel-Cross self-assigned this Oct 9, 2024
@Daniel-Cross Daniel-Cross linked an issue Oct 9, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5adfb0e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/353becf9-2242-4800-bed6-9e17cc0b06b8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Daniel-Cross Daniel-Cross added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cb6d002
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/560f833c-fd07-4183-9656-e70978e3ee2b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Daniel-Cross Daniel-Cross added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5384c97
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4552faa6-8a86-4fb9-b244-60d1eada6420

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Daniel-Cross Daniel-Cross marked this pull request as ready for review October 11, 2024 11:50
@Daniel-Cross Daniel-Cross requested review from a team as code owners October 11, 2024 11:50
@gambinish
Copy link
Contributor

Hey @Daniel-Cross could you plz provide the best way for me to recreate the buggy behavior vs fix? Also may want to run Bitrise once more as it may have flaked.

@legobeat legobeat changed the title fix: AxiosError: Network Error chore(sentry): don't report AxiosError: Network Error Oct 14, 2024
@Daniel-Cross Daniel-Cross added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 14, 2024
Copy link
Contributor

github-actions bot commented Oct 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4604866
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/75ebe899-afc7-4512-a89a-155ec8c1119c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Daniel-Cross Daniel-Cross added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 856771f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7c322584-ca9e-4b8c-96b7-dda477fbc4a0

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Daniel-Cross Daniel-Cross added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 21, 2024
Copy link
Contributor

github-actions bot commented Oct 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9427fc2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8575267d-a021-4b55-9b1b-22067cf7dabe

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Daniel-Cross Daniel-Cross added this pull request to the merge queue Oct 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 21, 2024
@Daniel-Cross Daniel-Cross added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
Copy link

@Daniel-Cross Daniel-Cross added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 1738ea0 Oct 22, 2024
37 checks passed
@Daniel-Cross Daniel-Cross deleted the 10778-sentry-axioserror-network-error branch October 22, 2024 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Sentry] AxiosError: Network Error
6 participants