Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating codeowners to remove mobile-devs from component library #11709

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Oct 9, 2024

Description

This PR updates the CODEOWNERS file by removing mobile developers from the component-library folder. The goal is to:

  • Prevent Prop Bloat: Streamline components and avoid unnecessary complexity.
  • Maintain Consistency: Ensure that we achieve 1:1 consistency across Figma, Extension, and Mobile environments.
  • Reduce Tech Debt: Centralize control over merge permissions to avoid inconsistencies and maintain clean component architecture.

Related Issues

Fixes: N/A

Manual Testing Steps

  1. Review the changes made to the CODEOWNERS file.
  2. Verify that mobile developers no longer have ownership permissions over the component-library folder.
  3. Confirm that merge permissions reflect the correct teams for maintaining the design system and consistency.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described and includes necessary testing evidence, such as recordings or screenshots.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Mobile label Oct 9, 2024
@georgewrmarshall georgewrmarshall self-assigned this Oct 9, 2024
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner October 9, 2024 15:46
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 9, 2024
Copy link

sonarqubecloud bot commented Oct 9, 2024

@brianacnguyen brianacnguyen added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 9, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 9, 2024
@georgewrmarshall georgewrmarshall added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit a7bd867 Oct 9, 2024
54 of 56 checks passed
@georgewrmarshall georgewrmarshall deleted the update-ds-codeowners branch October 9, 2024 19:55
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-design-system All issues relating to design system in Mobile
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants