Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding expandable message section to personal sign page #11703

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 9, 2024

Description

Expandable message section on personal sign page.

Related issues

Fixes: #11679

Manual testing steps

  1. Enable confirmation re-designs locally
  2. Go to test dapp
  3. Submit a personal sign request and check message section on the page

Screenshots/Recordings

Screen.Recording.2024-10-09.at.6.21.27.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 9, 2024
@jpuri jpuri requested review from a team as code owners October 9, 2024 13:20
Copy link
Contributor

github-actions bot commented Oct 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9816a99
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5be4d549-367e-4153-ad6c-a114a6a34cbb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Oct 9, 2024

@jpuri jpuri added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 1b6a814 Oct 9, 2024
41 of 42 checks passed
@jpuri jpuri deleted the message_section branch October 9, 2024 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add expandable message section on personal sign page
3 participants