-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: connect request completed source validation #11701
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11701 +/- ##
==========================================
+ Coverage 54.07% 54.21% +0.14%
==========================================
Files 1689 1709 +20
Lines 38546 38707 +161
Branches 4707 4736 +29
==========================================
+ Hits 20844 20986 +142
- Misses 16264 16272 +8
- Partials 1438 1449 +11 ☔ View full report in Codecov by Sentry. |
Description
The
Connect Request Completed
analytics event had a wrong sourcewalletconnect
when a dapp was connecting to the wallet from the in-app browser. This PR fixes source the validation.Related issues
Fixes: SDK-81
Manual testing steps
Pre-merge author checklist
Pre-merge reviewer checklist