fix: relax network symbol length validation

[bergeron]

Description

When adding a network with wallet_addEthereumChain, MetaMask was requiring the chain's symbol to be minimum of 2 characters. But there are networks with single character symbols.

Related issues

• Equivalent PR on extension: fix: relax network symbol length validation metamask-extension#24872
• [Bug]: Not allowed to add a new network where the symbol (ticker) consists of one letter #11217

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 48818fa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/812a99f6-ccae-43a7-86d2-d6397a67444b

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 80f8f43
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ca016d31-5b82-4333-99d6-d1df0bc57249

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.20%. Comparing base (9f29292) to head (856181c).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11693      +/-   ##
==========================================
+ Coverage   55.78%   56.20%   +0.41%     
==========================================
  Files        1786     1786              
  Lines       40362    40360       -2     
  Branches     5054     5054              
==========================================
+ Hits        22516    22684     +168     
+ Misses      16297    16123     -174     
- Partials     1549     1553       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 856181c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f87c276d-f8cb-4b35-8b5b-6a0550fc06b7

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[NicolasMassart]

Can you provide a unit test for this please?

[smilingkylan]

LGTM