Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade assets controllers v32.0.0 #11687

Merged
merged 5 commits into from
Oct 14, 2024
Merged

chore: upgrade assets controllers v32.0.0 #11687

merged 5 commits into from
Oct 14, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Oct 8, 2024 •
edited
Loading

Description

PR to upgrade assets-controllers to v32

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2024-10-11.at.16.33.43.mov
Screen.Recording.2024-10-11.at.16.35.28.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Oct 8, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@32.0.0 None +1 1.55 MB metamaskbot
npm/@metamask/preferences-controller@13.0.3 None 0 124 kB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@31.0.0, npm/@metamask/keyring-controller@16.1.0, npm/@metamask/message-manager@9.0.0, npm/@metamask/network-controller@18.1.3, npm/@metamask/polling-controller@7.0.0, npm/@metamask/preferences-controller@12.0.0

View full report↗︎

@sahar-fehri sahar-fehri changed the title Chore/upgrade assets controllers v32.0.0 Chore: upgrade assets controllers v32.0.0 Oct 8, 2024
@sahar-fehri sahar-fehri changed the title Chore: upgrade assets controllers v32.0.0 chore: upgrade assets controllers v32.0.0 Oct 8, 2024
@sahar-fehri sahar-fehri force-pushed the chore/upgrade-assets-controllers-v32.0.0 branch from 8b1ea4c to f4b791c Compare October 8, 2024 21:35
@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f4b791c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d83b0735-c17e-47d8-9e35-599d0ad58576

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8e0788e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d14e47b3-0dad-47a8-90b1-5611e5f93838

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review October 8, 2024 22:41
@sahar-fehri sahar-fehri requested review from a team as code owners October 8, 2024 22:41
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 1ee916a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/284fc125-714d-416d-b3ff-8256ab269e5f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@tommasini
Copy link
Contributor

tommasini commented Oct 10, 2024 •
edited
Loading

Hey @sahar-fehri this looks great! Would be possible to have a recording with tokens/nfts interactions? ( importing manually, auto detecting)

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 10, 2024
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 5260531
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d9fd79cd-6484-4bea-bf7c-c73e6aa8d53f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini
tommasini approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bd713c7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8960179e-bdb6-4eb9-9dc9-79df997710eb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sahar-fehri sahar-fehri added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 7863f59 Oct 14, 2024
43 checks passed
@sahar-fehri sahar-fehri deleted the chore/upgrade-assets-controllers-v32.0.0 branch October 14, 2024 13:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sahar-fehri @tommasini @gauthierpetetin