Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CircleCI Badge #1164

Merged
merged 2 commits into from
Oct 22, 2019
Merged

Add CircleCI Badge #1164

merged 2 commits into from
Oct 22, 2019

Conversation

Zidail
Copy link
Contributor

@Zidail Zidail commented Oct 22, 2019

Description

Adds a CircleCI Badge to the README.md

Zidail_metamask-mobile_at_add-circleci-badge

**Note: Might require a token depending on CircleCI project settings, but for now, seems ok as the last test passed and the badge is also "passing".

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves none.

@brunobar79 brunobar79 self-requested a review October 22, 2019 13:39
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you update it to specify the develop branch which is our default?

@Zidail
Copy link
Contributor Author

Zidail commented Oct 22, 2019

@brunobar79 Sure thing! Done!

@brunobar79 brunobar79 self-requested a review October 22, 2019 14:00
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brunobar79 brunobar79 merged commit 6fe8cbd into MetaMask:develop Oct 22, 2019
@Zidail Zidail deleted the add-circleci-badge branch October 22, 2019 14:02
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* Add CircleCI Badge

* Update circleci badge to check develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants