Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add custom and add popular network detox test #11632

Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix: add custom and add popular network detox test #11632

merged 2 commits into from
Oct 4, 2024

Conversation

SamuelSalas
Copy link
Contributor

@SamuelSalas SamuelSalas commented Oct 4, 2024 •
edited
Loading

Description

e2e/specs/networks/add-custom-rpc.spec.js and e2e/specs/networks/add-popular-networks.spec.js tests is failing on main, according to the regression test runs results provided by Bitrise.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Regression Test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/358e3dd8-5e2e-4e1d-a9af-8caab23e9465

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas added type-bug Something isn't working Run Smoke E2E Triggers smoke e2e on Bitrise Detox labels Oct 4, 2024
@SamuelSalas SamuelSalas self-assigned this Oct 4, 2024
@SamuelSalas SamuelSalas requested review from a team as code owners October 4, 2024 18:44
@SamuelSalas SamuelSalas linked an issue Oct 4, 2024 that may be closed by this pull request
[Bug]: Fix Add custom rpc detox test #11610
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: d433a8a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8ca8da96-c38e-4c9d-813e-14703696f893

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@SamuelSalas SamuelSalas added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 36036fe
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2ed21ed4-3cf7-4921-ade4-f01da055bdc2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cortisiko
cortisiko approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅ ✅

@SamuelSalas SamuelSalas enabled auto-merge October 4, 2024 19:30
@SamuelSalas SamuelSalas disabled auto-merge October 4, 2024 19:30
@SamuelSalas SamuelSalas enabled auto-merge October 4, 2024 19:30
chrisleewilcox
chrisleewilcox approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamuelSalas SamuelSalas added this pull request to the merge queue Oct 4, 2024
@vinnyhoward
Copy link
Contributor

LGTM✅

Merged via the queue into main with commit 142d12d Oct 4, 2024
48 checks passed
@SamuelSalas SamuelSalas deleted the fix/11610-add-custom-rpc-detox-test branch October 4, 2024 20:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@salimtb salimtb salimtb approved these changes

@cortisiko cortisiko cortisiko approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees

@SamuelSalas SamuelSalas

Labels
Detox release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets team-mobile-platform type-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix Add custom rpc detox test
6 participants
@SamuelSalas @vinnyhoward @chrisleewilcox @cortisiko @salimtb @gauthierpetetin