Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update UX CodeOwners responsibilities #11614

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

EtherWizard33
Copy link
Contributor

Description

This new list was provided after consulting with the team, ensuring it reflects our current structure.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ed after checking with the team's engineer manager
@EtherWizard33 EtherWizard33 marked this pull request as ready for review October 3, 2024 21:02
@EtherWizard33 EtherWizard33 requested a review from a team as a code owner October 3, 2024 21:02
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@EtherWizard33 EtherWizard33 added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 3, 2024
gambinish
gambinish previously approved these changes Oct 3, 2024
vinnyhoward
vinnyhoward previously approved these changes Oct 3, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
@EtherWizard33 EtherWizard33 dismissed stale reviews from gambinish and vinnyhoward via f3b0b05 October 3, 2024 21:20
.github/CODEOWNERS Outdated Show resolved Hide resolved
@EtherWizard33 EtherWizard33 requested a review from Cal-L October 3, 2024 21:28
Copy link

sonarqubecloud bot commented Oct 4, 2024

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 4093fdf Oct 4, 2024
37 checks passed
@EtherWizard33 EtherWizard33 deleted the chore-update-wallet-ux-code-owners branch October 4, 2024 13:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants