Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-ts): Convert app/components/Base/ListItem.js to TypeScript #11601

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 3, 2024

PR Description

Description

This PR converts the app/components/Base/ListItem.js file to TypeScript. The conversion includes adding type interfaces for props and subcomponents, ensuring all components have the correct types, and removing PropTypes as per the task requirements.

Related Issues

  • N/A

Manual Testing Steps

  1. Verify that the ListItem component and its subcomponents render correctly in the application.
  2. Check for any TypeScript errors or warnings in the console.
  3. Ensure that the component's functionality remains unchanged.

Author Checklist

  • Converted the file to TypeScript.
  • Added type interfaces for props and subcomponents.
  • Removed PropTypes.
  • Verified no semantic changes were made.

Reviewer Checklist

  • Review the TypeScript conversion for accuracy.
  • Confirm that no semantic changes were made.
  • Verify that the component renders correctly in the application.
  • Check for any TypeScript errors or warnings.

This Devin run was requested by naveen.
This Devin run was requested by naveen.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner October 3, 2024 14:14
@devin-ai-integration devin-ai-integration bot added team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: ae81b18
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2b2e31e5-b82a-47ab-b01a-ed80c457e0b6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarqubecloud bot commented Oct 3, 2024

Copy link
Contributor

@smilingkylan smilingkylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smilingkylan smilingkylan enabled auto-merge October 3, 2024 17:24
@smilingkylan smilingkylan removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 3, 2024
@smilingkylan smilingkylan added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 341e5e9 Oct 3, 2024
60 of 61 checks passed
@smilingkylan smilingkylan deleted the devin/convert-ts-ListItem-21830 branch October 3, 2024 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.33.0 Issue or pull request that will be included in release 7.33.0 Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants