Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix walletconnect source validation #11592

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Conversation

elefantel
Copy link
Contributor

@elefantel elefantel commented Oct 3, 2024

Description

This PR fixes a request source validation check for walletconnect. We previously checked if the metadata url matches the origin. However the origin could be wc::https://appkit-lab.reown.com/ or wc::https://opensea.io for example.

Related issues

Fixes: SDK-56

Manual testing steps

  1. Go to WallectConnect Dapp
  2. Connect using MetaMask
  3. Perform a transaction
  4. Check the MetaMask mobile analytics on Segment
  5. The request_source should be WalletConnect

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@elefantel elefantel requested review from a team as code owners October 3, 2024 07:40
@elefantel elefantel self-assigned this Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@elefantel elefantel marked this pull request as draft October 3, 2024 07:40
@github-actions github-actions bot added the team-sdk SDK team label Oct 3, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Oct 3, 2024
@elefantel elefantel added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Oct 3, 2024
@elefantel elefantel marked this pull request as ready for review October 3, 2024 10:25
@elefantel elefantel added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 3, 2024
@darkwing darkwing requested review from a team and removed request for a team October 4, 2024 18:02
@elefantel elefantel requested a review from a team as a code owner October 4, 2024 19:30
Copy link

sonarqubecloud bot commented Oct 4, 2024

@elefantel elefantel added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 55006ba Oct 7, 2024
37 checks passed
@elefantel elefantel deleted the fix-wallet-connect-source branch October 7, 2024 11:14
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 team-sdk SDK team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants