Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip onramp onboarding for returning user #11591

Merged
merged 25 commits into from
Oct 28, 2024
Merged

Conversation

bkirb
Copy link
Contributor

@bkirb bkirb commented Oct 3, 2024

Description

This tests that a returning user in the buy flow does not see the onboarding flow again, or the steps to select region and payment method. It should skip to the build quote screen.

Related issues

https://consensyssoftware.atlassian.net/browse/RAMPS-1871

Manual testing steps

All Onramp tests are passing

 PASS  e2e/specs/ramps/onramp.spec.js (52.479 s)
  smokeAssets Buy Crypto
    ✓ should select Region and Payment Method to see the Build Quote screen (16291 ms)
    ✓ should skip to the Build Quote screen for returning user (14077 ms)

Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        52.55 s, estimated 55 s

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bkirb bkirb changed the title test: fix test for returning user test: skip onramp onboarding for returning user Oct 3, 2024
@bkirb bkirb added the team-ramp issues related to Ramp features label Oct 3, 2024
@bkirb bkirb marked this pull request as ready for review October 3, 2024 03:56
@bkirb bkirb requested a review from a team as a code owner October 3, 2024 03:56
Base automatically changed from bkirby/rampsTest to main October 4, 2024 05:26
@bkirb bkirb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b1401a2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f628cfa7-a249-48ea-8569-8ea1225a6a39

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bkirb bkirb requested a review from AxelGes October 9, 2024 14:58
@bkirb
Copy link
Contributor Author

bkirb commented Oct 21, 2024

@chrisleewilcox I updated based on your feedback and tests are still passing ✅
2f85d6b

 PASS  e2e/specs/ramps/onramp.spec.js (54.788 s)
  smokeAssets Buy Crypto
    ✓ should select Region and Payment Method to see the Build Quote screen (17275 ms)
    ✓ should skip to the Build Quote screen for returning user (16008 ms)

Test Suites: 1 passed, 1 total
Tests:       2 passed, 2 total

@bkirb bkirb requested a review from chrisleewilcox October 21, 2024 04:45
SamuelSalas
SamuelSalas previously approved these changes Oct 21, 2024
Copy link
Contributor

@SamuelSalas SamuelSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bkirb bkirb requested a review from a team October 22, 2024 00:13
@bkirb bkirb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c6e3865
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07969fd7-1dea-485b-a2c7-3b61a417a72f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

@bkirb bkirb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 28, 2024
Copy link

Copy link
Contributor

github-actions bot commented Oct 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: eeeab87
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f2279cea-1440-4666-93c4-f6998cff23df

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bkirb bkirb added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit fe4ad1e Oct 28, 2024
43 checks passed
@bkirb bkirb deleted the bkirby/returningUserTest branch October 28, 2024 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants