feat(2796): permission settings replace some of the mock data by real data #11590
+287
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter the sdk versus in app browser vs wallet connect, for local testing only, prod will require a real source property
EtherWizard33
added
No QA Needed
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…at can be selected
… in some case this modal is displayed when switching from the global selector
…ng more than needed and it made the snapshot fail, TY snapshots.
…ing the connected flow
…f-the-mock-data-by-real-data
…ssion-settings-replace-some-of-the-mock-data-by-real-data
… the plumbing for the screens later in the flow to have the real data available
feat-2808-edit-network-happy-path # Please enter a commit message to explain why this merge is necessary,
…ording depending if it is an initial connection, and the number of networks
…rent wording depending if there is one or many accounts being requested or connected
vinnyhoward
reviewed
Nov 6, 2024
app/components/Views/AccountPermissions/ConnectionDetails/ConnectionDetails.tsx
Outdated
Show resolved
Hide resolved
EtherWizard33
added
Run Smoke E2E
|
EtherWizard33
added
Run Smoke E2E
…f-the-mock-data-by-real-data
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11590 +/- ##
==========================================
- Coverage 56.31% 56.26% -0.05%
==========================================
Files 1786 1788 +2
Lines 40375 40416 +41
Branches 5060 5068 +8
==========================================
+ Hits 22738 22741 +3
- Misses 16088 16128 +40
+ Partials 1549 1547 -2 ☔ View full report in Codecov by Sentry. |
tommasini
reviewed
Nov 7, 2024
app/components/Views/Settings/PermissionsSettings/PermissionsManager.tsx
Show resolved
Hide resolved
tommasini
approved these changes
Nov 7, 2024
EtherWizard33
added
Run Smoke E2E
|
vinnyhoward
approved these changes
Nov 7, 2024
…f-the-mock-data-by-real-data
…f-the-mock-data-by-real-data
|
EtherWizard33
deleted the
feat-2796-permission-settings-replace-some-of-the-mock-data-by-real-data
branch
gauthierpetetin
added
the
release-7.36.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The data is not ready yet to display permissions of all source, it will require a 'source' attribute to say if its sdk, wallet connect or in app browser. This is an attempt at filtering them based on differences the 'might' always have, but even if it did work now, it could break anytime because it requires a real source property meant to identify the source.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist