-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1653 first feature flag poc #11578
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 70c9251 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need tests!
…k/metamask-mobile into feat/1653-first-feature-flag-poc
Bitrise✅✅✅ Commit hash: 0099fc0 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify test name so they are easy to understand the use case. People hardly think in reverse.
Direct positive sentences are easier even if implementation requires an expect.not.to...
app/components/hooks/MinimumVersions/useMinimumVersions.test.ts
Outdated
Show resolved
Hide resolved
app/components/hooks/MinimumVersions/useMinimumVersions.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Aggree with Nico comments! let me know when resolved and I will approve it again
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Co-authored-by: Nico MASSART <NicolasMassart@users.noreply.github.com>
Quality Gate passedIssues Measures |
Bitrise❌❌❌ Commit hash: 5dd76e9 Note
Tip
|
Description
mobileMinimumVersions.appMinimumBuild
feature flag in LaunchDarklyRelated issues
Fixes: #1653
This PR builds upon work in previous LD setup work: #10294
Manual testing steps
app/components/hooks/MinimumVersions/useMinimumVersions.tsx
featureFlags?.mobileMinimumVersions?.appMinimumBuild > currentBuildNumber;
to:
featureFlags?.mobileMinimumVersions?.appMinimumBuild > 0;
Screenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-03.at.15.12.17.mp4
Pre-merge author checklist
Pre-merge reviewer checklist