Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: initial off-ramp test to show build quote screen #11573

Merged
merged 25 commits into from
Oct 22, 2024
Merged

Conversation

bkirb
Copy link
Contributor

@bkirb bkirb commented Oct 2, 2024

Description

This is the initial test and foundation for Off-Ramp testing. It should go through the onboarding screen, select region, select payment method, and show the screen to build a Sell quote.

Related issues

https://consensyssoftware.atlassian.net/browse/RAMPS-1869

Manual testing steps

This test is consistently passing:

 PASS  e2e/specs/ramps/offramp.spec.js (36.081 s)
  smokeAssets OffRamp
    ✓ should select Region and Payment Method to see the Build Sell Quote screen (16087 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        36.139 s

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bkirb bkirb changed the base branch from main to bkirby/rampsMobileTest October 2, 2024 14:29
@bkirb bkirb changed the base branch from bkirby/rampsMobileTest to bkirby/rampsTest October 2, 2024 14:30
@bkirb bkirb added the team-ramp issues related to Ramp features label Oct 3, 2024
@bkirb bkirb marked this pull request as ready for review October 3, 2024 02:57
@bkirb bkirb requested a review from a team as a code owner October 3, 2024 02:57
@bkirb bkirb changed the title [draft] initial ramps sell test test: initial off-ramp test to show build quote screen Oct 3, 2024
Base automatically changed from bkirby/rampsTest to main October 4, 2024 05:26
@bkirb bkirb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 39a7e12
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/704da243-9347-414e-ac69-2978ba635f72

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bkirb bkirb requested a review from wachunei October 7, 2024 18:26
@bkirb bkirb requested a review from AxelGes October 9, 2024 14:58
@bkirb
Copy link
Contributor Author

bkirb commented Oct 21, 2024

@chrisleewilcox @cortisiko I made updates based on your feedback and the test is still passing ✅
888d965

 PASS  e2e/specs/ramps/offramp.spec.js (110.23 s)
  smokeAssets Off-Ramp
    ✓ should display Build Sell Quote based on selected Region and Payment (15618 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total

Copy link
Contributor

@SamuelSalas SamuelSalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 🌮 🌮

@bkirb bkirb added this pull request to the merge queue Oct 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 22, 2024
@bkirb bkirb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9f92357
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fd4dd8d3-2b53-4fcb-b6de-d25f2d3fde7e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@bkirb bkirb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ef2ffcf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/21536deb-2d98-45ac-be02-55178dc21093

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@bkirb bkirb added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 1582859 Oct 22, 2024
43 checks passed
@bkirb bkirb deleted the bkirby/rampsSell branch October 22, 2024 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants