Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add url value component for use in re-designed confirmation pages #11567

Merged
merged 23 commits into from
Oct 4, 2024
Merged

feat: add url value component for use in re-designed confirmation pages #11567

merged 23 commits into from
Oct 4, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Oct 2, 2024

Description

Add url value component for use in re-designed confirmation pages

Related issues

Fixes: #11496

Manual testing steps

  1. Run storybook locally
  2. Check confirmations -> info row story

Screenshots/Recordings

Screenshot 2024-10-02 at 3 08 32 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Oct 2, 2024
@jpuri jpuri requested review from a team as code owners October 2, 2024 09:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri requested a review from a team as a code owner October 4, 2024 10:08
@jpuri jpuri requested a review from a team as a code owner October 4, 2024 10:54
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 632cbb0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4283bf5c-747b-4537-bd78-3fa8a1815f9c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Base automatically changed from expandable_section to main October 4, 2024 12:51
@jpuri jpuri dismissed stale reviews from matthewwalsh0 and pedronfigueiredo October 4, 2024 12:51

The base branch was changed.

jpuri
jpuri commented Oct 4, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8b643f6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c8258b13-99d4-4a4c-bc10-2826b432d450

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jpuri jpuri added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit c531cf8 Oct 4, 2024
43 checks passed
@jpuri jpuri deleted the url_value branch October 4, 2024 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@pedronfigueiredo pedronfigueiredo Awaiting requested review from pedronfigueiredo

Assignees
No one assigned
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create URL value component for key->value row
4 participants
@jpuri @pedronfigueiredo @matthewwalsh0 @gauthierpetetin