Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix/use portfolio home page #11554

Merged
merged 4 commits into from
Oct 1, 2024
Merged

fix: Fix/use portfolio home page #11554

merged 4 commits into from
Oct 1, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Oct 1, 2024 •
edited
Loading

Description

Replaces the browser home page from https://home.metamask.io to https://portfolio.metamask.io/explore?MetaMaskEntry=mobile

Related issues

Fixes: Thread - https://consensys.slack.com/archives/C07PHNQ61SA/p1727810879864649

Manual testing steps

  1. Install a new version of the app
  2. Switch to the browser tab
  3. Default home page should show portfolio explore page

Screenshots/Recordings

Before

After

portfolio-home-page.mov

Old MM home still works
image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested a review from a team as a code owner October 1, 2024 20:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise release-blocker This bug is blocking the next release Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed team-mobile-platform labels Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 96a1701
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d3949131-aaef-4f59-ae4b-29ce744fe39a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0ac56ee
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/182a9c51-5564-46c9-af66-56d8375b238e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cortisiko
cortisiko approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ ✅ ✅

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Cal-L Cal-L added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 3084746 Oct 1, 2024
42 of 46 checks passed
@Cal-L Cal-L deleted the fix/use-portfolio-home-page branch October 1, 2024 23:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 1, 2024
@gauthierpetetin gauthierpetetin added the release-7.33.0 Issue or pull request that will be included in release 7.33.0 label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
release-7.33.0 Issue or pull request that will be included in release 7.33.0 release-blocker This bug is blocking the next release Run Smoke E2E Triggers smoke e2e on Bitrise Sev1-high An issue that may have caused fund loss or access to wallet in the past & may still be ongoing
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cal-L @cortisiko @gauthierpetetin