Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(js-ts): Convert app/components/Views/AndroidBackHandler/index.js to TypeScript #11546

Merged
merged 8 commits into from
Oct 10, 2024
Merged

chore(js-ts): Convert app/components/Views/AndroidBackHandler/index.js to TypeScript #11546

merged 8 commits into from
Oct 10, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 1, 2024 •
edited
Loading

chore(js-ts): Convert app/components/Views/AndroidBackHandler/index.js to TypeScript

Description

This PR converts the AndroidBackHandler component from JavaScript to TypeScript. The navigation prop is now typed using NavigationProp<any>, and propTypes have been removed.

Labels

  • needs-dev-review
  • team-mobile-platform
  • skip-sonar-cloud
  • Run Smoke E2E

This Devin run was requested by naveen.

If you have any feedback, you can leave comments in the PR and I'll address them in the app!

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner October 1, 2024 16:35
@devin-ai-integration devin-ai-integration bot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Oct 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 60bf8fc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/198d4841-0d32-4bb0-9e79-b0b5f5f02fea

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@smilingkylan smilingkylan added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E Triggers smoke e2e on Bitrise and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 3, 2024
@smilingkylan smilingkylan requested a review from a team as a code owner October 3, 2024 17:58
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 432872b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4d696752-452c-40f8-9822-2da0de63da7f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@smilingkylan smilingkylan added Run Smoke E2E Triggers smoke e2e on Bitrise and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 3, 2024
smilingkylan
smilingkylan approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@smilingkylan smilingkylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smilingkylan smilingkylan added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. and removed skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Oct 10, 2024
@smilingkylan smilingkylan removed the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Oct 10, 2024
@smilingkylan smilingkylan added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Oct 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarCloud

@smilingkylan smilingkylan added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 092d567 Oct 10, 2024
36 of 37 checks passed
@smilingkylan smilingkylan deleted the devin/convert-ts-AndroidBackHandler-21548 branch October 10, 2024 23:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Devin-Apps Devin-Apps Devin-Apps left review comments

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@smilingkylan smilingkylan smilingkylan approved these changes

Assignees
No one assigned
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smilingkylan @vinnyhoward @Devin-Apps @gauthierpetetin