feat: expandable section for use in confirmation pages #11528

jpuri · 2024-10-01T12:42:26Z

Description

Adding an expandable section to be used in confirmation pages.

Related issues

Fixes: #11432

Manual testing steps

Run storybook locally
Check confirmations -> expandable section story

Screenshots/Recordings

Screen.Recording.2024-10-01.at.5.51.52.PM.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-10-01T12:42:42Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2024-10-01T12:43:01Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4392020
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4435111b-37dc-4ca4-a508-fd1190dbc67b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

app/components/Views/confirmations/components/UI/ExpandableSection/ExpandableSection.tsx

app/components/Views/confirmations/components/UI/InfoRow/InfoSection/InfoSection.tsx

codecov-commenter · 2024-10-02T05:51:10Z

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (key_value_component@a2d80d8). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...UI/ExpandableSection/ExpandableSection.stories.tsx	0.00%	3 Missing ⚠️
...rmations/components/UI/InfoRow/InfoRow.stories.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                   @@
##             key_value_component   #11528   +/-   ##
======================================================
  Coverage                       ?   53.88%           
======================================================
  Files                          ?     1647           
  Lines                          ?    38238           
  Branches                       ?     4653           
======================================================
  Hits                           ?    20603           
  Misses                         ?    16211           
  Partials                       ?     1424

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The base branch was changed.

github-actions · 2024-10-02T15:58:06Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 265099a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2e305ea3-5059-4515-9ba0-723ace595d80

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

…ile into expandable_section

github-actions · 2024-10-02T16:22:11Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8512a23
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/31390420-9ad2-4a48-b7f9-c26a14e4b351

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

app/components/Views/confirmations/components/UI/ExpandableSection/ExpandableSection.tsx

…ile into expandable_section

github-actions · 2024-10-04T09:59:39Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 74de008
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d828a865-5653-4137-98f8-b566a41bb9a6

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarqubecloud · 2024-10-04T10:17:54Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jpuri added 4 commits September 30, 2024 20:17

Adding key-value component

bd44689

update

a2d80d8

Merge branch 'main' into key_value_component

88688cc

Adding expandable section for use in confirmation pages

4392020

jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team labels Oct 1, 2024

jpuri requested review from a team as code owners October 1, 2024 12:42

Merge branch 'main' into key_value_component

011ea64

matthewwalsh0 previously approved these changes Oct 1, 2024

View reviewed changes

jpuri added 2 commits October 2, 2024 09:29

Merge branch 'main' into key_value_component

3b9a7d8

Update

19b1bd5

jpuri added 2 commits October 2, 2024 19:29

Merge branch 'main' into key_value_component

33a48a0

Merge branch 'key_value_component' into expandable_section

f800c67

Base automatically changed from key_value_component to main October 2, 2024 15:19

jpuri requested a review from matthewwalsh0 October 2, 2024 15:48

Merge branch 'main' into expandable_section

265099a

jpuri enabled auto-merge October 2, 2024 15:49

jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 2, 2024

jpuri added 2 commits October 2, 2024 21:50

update

784c8fa

Merge branch 'expandable_section' of github.com:MetaMask/metamask-mob…

8512a23

…ile into expandable_section

jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 2, 2024

pedronfigueiredo previously approved these changes Oct 2, 2024

View reviewed changes

update

ed20942

jpuri dismissed pedronfigueiredo’s stale review via ed20942 October 2, 2024 17:04

jpuri requested a review from pedronfigueiredo October 2, 2024 23:05

matthewwalsh0 previously approved these changes Oct 3, 2024

View reviewed changes

pedronfigueiredo previously approved these changes Oct 3, 2024

View reviewed changes

Merge branch 'main' into expandable_section

e8ee129

jpuri requested a review from a team as a code owner October 3, 2024 09:46

EtherWizard33 reviewed Oct 3, 2024

View reviewed changes

app/components/Views/confirmations/components/UI/ExpandableSection/ExpandableSection.tsx Outdated Show resolved Hide resolved

app/components/Views/confirmations/components/UI/ExpandableSection/ExpandableSection.tsx Outdated Show resolved Hide resolved

jpuri added 2 commits October 4, 2024 15:27

update

335306f

Merge branch 'expandable_section' of github.com:MetaMask/metamask-mob…

74de008

…ile into expandable_section

jpuri dismissed stale reviews from matthewwalsh0 and pedronfigueiredo via 74de008 October 4, 2024 09:57

jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 4, 2024

Merge branch 'main' into expandable_section

638c0d5

jpuri requested review from EtherWizard33, matthewwalsh0 and pedronfigueiredo October 4, 2024 10:59

EtherWizard33 approved these changes Oct 4, 2024

View reviewed changes

pedronfigueiredo approved these changes Oct 4, 2024

View reviewed changes

jpuri added this pull request to the merge queue Oct 4, 2024

Merged via the queue into main with commit 7f41cef Oct 4, 2024
36 of 37 checks passed

jpuri deleted the expandable_section branch October 4, 2024 12:51

github-actions bot locked and limited conversation to collaborators Oct 4, 2024

gauthierpetetin added the release-7.34.0 label Oct 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: expandable section for use in confirmation pages #11528

feat: expandable section for use in confirmation pages #11528

jpuri commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024 •

edited by metamaskbot

Loading

codecov-commenter commented Oct 2, 2024

github-actions bot commented Oct 2, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 2, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 4, 2024 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Oct 4, 2024

feat: expandable section for use in confirmation pages #11528

feat: expandable section for use in confirmation pages #11528

Conversation

jpuri commented Oct 1, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024 • edited by metamaskbot Loading

Bitrise

codecov-commenter commented Oct 2, 2024

Codecov Report

github-actions bot commented Oct 2, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 2, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Oct 4, 2024 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Oct 4, 2024

Quality Gate passed

github-actions bot commented Oct 1, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 2, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 2, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Oct 4, 2024 •

edited by metamaskbot

Loading