Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(js-ts): Convert app/components/UI/StyledButton/styledButtonStyles.js to TypeScript #11525

Merged
merged 9 commits into from
Oct 10, 2024
Merged

chore(js-ts): Convert app/components/UI/StyledButton/styledButtonStyles.js to TypeScript #11525

merged 9 commits into from
Oct 10, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Oct 1, 2024 •
edited
Loading

This PR updates the TypeScript conversion for the StyledButton component. It removes type annotations for fontStyle and containerStyle, ensuring alignment with the latest requirements.

@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner October 1, 2024 10:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-ai AI team (for the Devin AI bot) label Oct 1, 2024
@devin-ai-integration devin-ai-integration bot added team-mobile-platform needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. Run Smoke E2E Triggers smoke e2e on Bitrise No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 1, 2024
@smilingkylan smilingkylan added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 2, 2024
@smilingkylan smilingkylan requested a review from a team as a code owner October 3, 2024 17:43
smilingkylan
smilingkylan approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@smilingkylan smilingkylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MetaMask MetaMask deleted a comment from github-actions bot Oct 3, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Oct 3, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
62.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@smilingkylan smilingkylan added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6d7ad74
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0094c5da-bba3-4f42-a787-1a55f878a6f6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@smilingkylan smilingkylan added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit df6255a Oct 10, 2024
42 of 43 checks passed
@smilingkylan smilingkylan deleted the devin/convert-ts-app-components-UI-StyledButton-styledButtonStyles.js-29628 branch October 10, 2024 20:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@smilingkylan smilingkylan smilingkylan approved these changes

Assignees
No one assigned
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-ai AI team (for the Devin AI bot) team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smilingkylan @vinnyhoward @gauthierpetetin